[GEODE-5064] Remove unused code and if clause that does not get thrown

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.7.0
• Component/s: querying
• Labels: pull-request-available
• Assignee: Jason Huynh
• Reporter: Jason Huynh
• Created: 12/Apr/18 21:34
• Updated: 03/Oct/18 21:37
• Resolved: 13/Apr/18 20:24

Description

There appears to be an exception that should be thrown, but upon futher inspection, this clause can never be hit because the boolean it checks is never set to true;

 

In LocalRegion:

logger.info("Failed to create index {} on region {} with exception: {}",
icd.getIndexName(), this.getFullPath(), ex);

// Check if the region index creation is from cache.xml, in that case throw exception.
// Other case is when bucket regions are created dynamically, in that case ignore the
// exception.
if (internalRegionArgs.getDeclarativeIndexCreation())

{ throw new InternalGemFireError(LocalizedStrings.GemFireCache_INDEX_CREATION_EXCEPTION_1 .toLocalizedString(icd.getIndexName(), this.getFullPath()), ex); }

Issue Links

• links to: GitHub Pull Request #1790