[GEODE-5044] Protobuf server does not log full stacktrace of failures

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.7.0
• Component/s: client/server
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Dan Smith
• Created: 10/Apr/18 19:37
• Updated: 03/Oct/18 21:38
• Resolved: 13/Apr/18 00:40

Description

While doing some testing, we noticed that the protobuf server was not logging the stacktrace of some failures, which makes debugging difficult.

Looking at the code, it looks like we were trying to log the exception as a separate log line. But in this case the exception just gets turned into a string

logger.error("Invalid execution context found for operation {}", requestType);
logger.error(exception); //This just prints the toString of the exception

Instead, we should be logging the exception and message as a single line

logger.error("Invalid execution context found for operation {}", requestType, exception);

Issue Links

• links to: GitHub Pull Request #1769