[GEODE-5043] Protobuf server and client are sending multiple packets for a single request

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.7.0
• Component/s: client/server
• Labels: pull-request-available
• Assignee: Dan Smith
• Reporter: Dan Smith
• Created: 10/Apr/18 19:34
• Updated: 03/Oct/18 21:38
• Resolved: 18/Apr/18 23:04

Description

While doing some performance testing, we discovered that the protobuf client and protobuf server are actually sending multiple packets per request and response based on the the LinuxSystemStats.xmitPackets. The messages are small enough they should fit in a single packet.

 

Looking at the code, it looks like in both the client and the server we are writing directly to socket.getOutputStream(). As soon as data is written to that outputstream it could be sent to the the remote side. Wrapping that in the BufferedOutputStream eleminates the duplicate packets and improves the performance.

Issue Links

• links to: GitHub Pull Request #1768