[GEODE-4705] Clean up Failure object creation in protobuf code

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.5.0
• Component/s: client/server
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Brian Rowe
• Created: 17/Feb/18 00:45
• Updated: 09/Apr/18 22:36
• Resolved: 21/Feb/18 17:37

Description

Currently we see may calls to the static Failure.of() method with several lines containing dozens of calls to builder objects.  Given that this same pattern occurs all over the place, this method should be refactored to do the building code internally.

Issue Links

• links to: GitHub Pull Request #1472