[GEODE-4691] Gfsh command Start Locator shows inconsistent behavior with auto-connecting with a Security Manager

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.5.0
• Component/s: docs, gfsh, security
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Barbara Pruijn
• Created: 15/Feb/18 23:34
• Updated: 09/Apr/18 22:36
• Resolved: 23/Feb/18 16:13

Description

When starting a locator in gfsh like this

start locator --name=locator1

the default behavior is to auto-connect gfsh to the locator.

From the gfsh start locator help:

connect
When connect is set to false , Gfsh does not automatically connect to the locator which is started
using this command.
Required: false
Default (if the parameter is specified without value): true
Default (if the parameter is not specified): true

When starting the locator with a Security Manager like this

start locator --name=locator1 --J=-Dgemfire.security-manager=org.apache.geode.examples.SimpleSecurityManager

The result is that gfsh does not auto connect to the locator. However this is not listed in the help command and is inconsistent in the user expectation.

 

Solution and accceptance criteria:

Update the output of 

start locator --J=-Dgemfire.security-manager=org.apache.geode.examples.SimpleSecurityManager

to indicate that it is not auto-connected. New output:

Security Manager is enabled - unable to auto-connect. Please use connect with --user and --password to connect to locator.

Update gfsh help to correctly list the behavior when the Security Manager is set via the --J parameter

 

gfsh should display correct connect help message for

help start locator

when using Security Manager.

connect
When connect is set to false or when locator is started with a security manager using --J=-Dgemfire.security-manager option, Gfsh does not automatically connect to the locator which is started using this command.
Required: false
Default (if the parameter is specified without value): true
Default (if the parameter is not specified): true

 

Issue Links

• links to: GitHub Pull Request #1478