[GEODE-4637] Geode Native uses GEODE rather than GEODE_HOME

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.8.0
• Component/s: native client
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Addison
• Created: 08/Feb/18 18:53
• Updated: 20/Mar/19 20:38
• Resolved: 20/Mar/19 20:36

Description

The java side of things uses GEODE_HOME environment variable to point to the Geode install directory containing the /bin.

https://github.com/apache/geode-examples/blob/5b413a34e30790a6631332cfa1f4b485a487abcb/build.gradle

Geode Native uses the environment variable GEODE.
https://github.com/apache/geode-native/blob/develop/BUILDING.md

This is confusing. It would be best if we standardize on GEODE_HOME.

 

This does not mean changing the FindGeode.cmake module's GEODE_ROOT configuration variable. The only change should be in which environment variable is used to search for Geode if the GEODE_ROOT is not explicitly set.

Issue Links

• links to: GitHub Pull Request #254
• links to: GitHub Pull Request #268