[GEODE-4627] Protobuf server operation handlers do not check for low-memory conditions

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Fix Version/s: 1.5.0
• Component/s: client/server
• Assignee: Brian Baynes
• Reporter: Bruce J Schuchardt
• Created: 07/Feb/18 22:25
• Updated: 12/Feb/18 18:19
• Resolved: 12/Feb/18 18:18

Description

The new Protobuf-based client/server operation handlers are not checking to see if memory is low. For instance, the Java client does this check in handling function execution requests:

        HeapMemoryMonitor hmm =
            ((InternalResourceManager) cache.getResourceManager()).getHeapMonitor();
        if (functionObject.optimizeForWrite() && cache != null && hmm.getState().isCritical()
            && !MemoryThresholds.isLowMemoryExceptionDisabled()) {
          Set<DistributedMember> sm = Collections.singleton((DistributedMember) cache.getMyId());
          Exception e = new LowMemoryException(
              LocalizedStrings.ResourceManager_LOW_MEMORY_FOR_0_FUNCEXEC_MEMBERS_1
                  .toLocalizedString(new Object[] {functionObject.getId(), sm}),
              sm);

          sendException(hasResult, clientMessage, e.getMessage(), serverConnection, e);
          return;
        }