[GEODE-4375] Mismatch deserialization of TxCommitMessage

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.5.0
• Component/s: serialization, transactions
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Masaki Yamakawa
• Created: 25/Jan/18 07:35
• Updated: 08/Jun/18 19:44
• Resolved: 31/Jan/18 18:29

Description

I am migrating from GemFire 7.x to Geode. After migration, An exception is now thrown in transaction commit. I would like to fix this problem.

There are the following three patterns as a communication of a transaction. In this last pattern, a deserialization exception is thrown.

• CacheServer (transaction) -> CacheServer
• Client (transaction) -> CacheServer
• CacheServer via Pool (transaction) -> CacheServer

In toData of TxCommitMessage.RegionCommit.FarSideEntryOp it is decided whether or not to serialize ShadowKey depending on whether ClientVersion exists or not. In the case of the last pattern, it is serialized because ClientVersion exists. In fromData case, it decides whether or not to deserialize by whether it is a Loner or not. In the case of the last pattern, it is not Loner. As a result, a deserialization exception is thrown.

Therefore, instead of judging by the internal status of each process, I'd like to send a flag as to whether ShadowKey exists or not.
Note: The disadvantage is that bytes are increased slightly.

Issue Links

• is related to: GEODE-5305 TXCommitMessage deserialization can result in warning if cache closes
• links to: GitHub Pull Request #1340
• links to: GitHub Pull Request #1363