Uploaded image for project: 'Geode'
  1. Geode
  2. GEODE-4236

ConfigureEvictionThroughGfsh AcceptanceTest fails due to timeout -- Reconsider default timeout for GfshRule

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.5.0
    • gfsh
    • None

    Description

      org.apache.geode.management.internal.cli.commands.ConfigureEvictionThroughGfsh > configureEvictionByEntryCount FAILED
          org.junit.ComparisonFailure: expected:<[tru]e> but was:<[fals]e>
              at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
              at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
              at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
              at org.apache.geode.test.junit.rules.gfsh.GfshScript.awaitLoudly(GfshScript.java:141)
              at org.apache.geode.test.junit.rules.gfsh.GfshScript.awaitIfNecessary(GfshScript.java:112)
              at org.apache.geode.test.junit.rules.gfsh.GfshRule.execute(GfshRule.java:98)
              at org.apache.geode.test.junit.rules.gfsh.GfshScript.execute(GfshScript.java:105)
              at org.apache.geode.management.internal.cli.commands.ConfigureEvictionThroughGfsh.configureEvictionByEntryCount(ConfigureEvictionThroughGfsh.java:50)
      

      Examining the test itself, it seems that the call

          GfshExecution execution = GfshScript
              .of("start locator --name=locator", "start server --name=server",
                  "create region --name=region1 --eviction-action=local-destroy --eviction-entry-count=1000 --type=REPLICATE",
                  "create region --name=region2 --eviction-action=overflow-to-disk --eviction-entry-count=1000 --type=REPLICATE",
                  "create region --name=region3 --eviction-action=overflow-to-disk --eviction-entry-count=1000 --type=REPLICATE_PERSISTENT",
                  "create region --name=region4 --eviction-action=local-destroy --eviction-entry-count=1000 --type=LOCAL",
                  "create region --name=region5 --eviction-action=overflow-to-disk --eviction-entry-count=1000 --type=LOCAL")
              .execute(gfsh);
      

      is executing under the default GfshExecution timeout of 2 minutes. 2 might be optimistic for the creation of two members and five regions, depending on computational resources available.

      The use of the 2 minute timeout may be the result of an unclear testing API, or might consider prepending a message with the execution's timeout to the gfsh output stream.

      Attachments

        Issue Links

          Activity

            People

              khowe Ken Howe
              prhomberg Patrick Rhomberg
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: