[GEODE-4186] Replace all decayed array parameters (Type *) with std::vector.

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Component/s: native client
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Jacob Barrett
• Created: 03/Jan/18 19:50
• Updated: 20/Apr/18 19:56
• Resolved: 02/Feb/18 16:42

Description

Replace all decayed array parameters (Type *) with std::vector. For example

void writeIntArray(int32_t* array, size_t length);
int32_t* readIntArray(size_t& length);

to

void writeIntArray(const std::vector<int32_t>& array);
std::vector<int32_t> readIntArray();

This removes the ambiguity around memory ownership, makes the method functional (no out param), collocates the length and other array attributes with the vector, and removes null.

Issue Links

• links to: GitHub Pull Request #194