[GEODE-3723] Reconsider using Optional<String> as the parameter for getRequiredPermissions

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.0
• Component/s: security
• Assignee: Jens Deppe
• Reporter: Dan Smith
• Created: 29/Sep/17 00:59
• Updated: 20/Apr/18 19:53
• Resolved: 04/Oct/17 22:13

Description

The new method on function, getRequiredPermissions takes an Optional<String> as parameter.

At point point, we added a parameterized type to the function interface (Function<T>). However, if someone tries to implement Function without the type (eg implements Function instead of implemments Function<Object>), then they get the below compilation error:

Error:(85, 41) java: name clash: getRequiredPermissions(java.util.Optional<java.lang.String>) in org.apache.geode.cache.lucene.internal.distributed.WaitUntilFlushedFunction and getRequiredPermissions(java.util.Optional<java.lang.String>) in org.apache.geode.cache.execute.Function have the same erasure, yet neither overrides the other

In addition to this annoyance Optional is generally discouraged as a parameter to a method in favor of method overloading. At least my IDE is providing a warning to that effect. Maybe having an overloaded method for getRequiredPermissions would be better?