[GEODE-3584] Refactor ServerLauncher and LocatorLauncher to eliminate code duplication

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.2.0
• Component/s: gfsh
• Assignee: Unassigned
• Reporter: Ken Howe
• Created: 08/Sep/17 19:42
• Updated: 23/Feb/18 06:51

Description

There is some duplication of code in the Launcher classes that can be eliminated. Both classes have methods such as getBindAddress (called getServerBindAddress in ServerLauncher) that could be hoisted into AbstractLauncher class that they both extend. The same goes for the inner State classes of the Launchers; they have methods that could be moved to AbstractLauncher.ServiceState.

Sub-Tasks

• Reconcile and unify ServerLauncher.Command and LocatorLauncher.Command enums: Open