Uploaded image for project: 'Geode'
  1. Geode
  2. GEODE-3057

Keep Thread Local Comm Buffer in selector thread

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: client/server
    • Labels:

      Description

      In ServerConnection.run(), we currently pull a comm buffer from the pool every time that

      {run} is called by a selector, and release it back after the particular message.

      This buffer is allocated in a ThreadLocal, so it would make more sense to have the selector thread own a buffer that all commands running on that selector can use.

      As a side note, maybe it would make sense to split the run function in two, with {run}

      being called in the connection-per-thread case and doMessageOnSelector or so being called by the selector?

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              gosullivan Galen O'Sullivan
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: