[GEODE-3054] GfshParser is unnecessarily interpreting escaped sequences in command options.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Component/s: gfsh
• Assignee: Jinmei Liao
• Reporter: Jinmei Liao
• Created: 08/Jun/17 18:07
• Updated: 17/Jun/17 18:04
• Resolved: 09/Jun/17 19:31

Description

The following commands failed on windows because GfshParser is treating \r in the pathname as a carriage return.

gfsh>describe offline-disk-store --name=testDiskStore --disk-dirs=R:\var\vcap\data\regrResults\cli\2017-06-07-13-1942\alterCompressor-0608-035833\vm_2_dataStore1_disk_1

[error 2017/06/08 10:18:30.655 PDT <Gfsh Launcher> tid=0x1e] Unable to create di
egrResults\cli\2017-06-07-13-19-42\alterCompressor-0608-035833\vm_2_dataStore1_d
isk_1
org.apache.geode.GemFireIOException: Unable to create directory : R:\var\vcap\da
egrResults\cli\2017-06-07-13-19-42\alterCompressor-0608-035833\vm_2_dataStore1_d
isk_1
at org.apache.geode.internal.cache.DiskStoreFactoryImpl.checkIfDirectori
esExist(DiskStoreFactoryImpl.java:211)
at org.apache.geode.internal.cache.DiskStoreFactoryImpl.setDiskDirs(Disk
StoreFactoryImpl.java:232)
at org.apache.geode.internal.cache.DiskStoreImpl.createForOffline(DiskSt
oreImpl.java:4260)
at org.apache.geode.internal.cache.DiskStoreImpl.createForOffline(DiskSt
oreImpl.java:4220)
at org.apache.geode.internal.cache.DiskStoreImpl.dumpInfo(DiskStoreImpl.
java:4305)
at org.apache.geode.management.internal.cli.commands.DiskStoreCommands.d
escribeOfflineDiskStore(DiskStoreCommands.java:1154)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.
java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcces
sorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.springframework.util.ReflectionUtils.invokeMethod(ReflectionUtils
.java:216)
at org.apache.geode.management.internal.cli.shell.GfshExecutionStrategy.
execute(GfshExecutionStrategy.java:91)
at org.springframework.shell.core.AbstractShell.executeCommand(AbstractS
hell.java:134)
at org.apache.geode.management.internal.cli.shell.Gfsh.promptLoop(Gfsh.j
ava:1022)
at org.springframework.shell.core.JLineShell.run(JLineShell.java:179)
at java.lang.Thread.run(Thread.java:748)

Could not process command due to error. An error occurred while describing offli
egrResults\cli\2017-06-07-13-19-42\alterCompressor-0608-035833\vm_2_dataStore1_d
isk_1

gfsh>