[GEODE-2735] CliUtil.isGfshVM is not thread-safe and unnecessary

• Type: Wish
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.0
• Component/s: gfsh
• Assignee: Kirk Lund
• Reporter: Kirk Lund
• Created: 30/Mar/17 16:03
• Updated: 20/Apr/18 19:53
• Resolved: 09/Aug/17 17:46

Description

The top of CliUtil defines:

public static final String GFSHVM_IDENTIFIER = "gfsh";
public static boolean isGfshVM = Boolean.getBoolean(GFSHVM_IDENTIFIER);

Tests then set isGfshVM and unset that in setup/teardown. Various GFSH commands check the state of this boolean.

It would be thread-safe if it were volatile, but I'd prefer to just get rid of this static variable.