[GEODE-2161] FilterRoutingInfo.FilterInfo.toData does unneeded copying

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.1.0
• Assignee: Xiaojian Zhou
• Reporter: Xiaojian Zhou
• Created: 01/Dec/16 01:51
• Updated: 20/Apr/18 19:53
• Resolved: 02/Dec/16 00:15

Description

This is #52614

FilterInfo.toData (that was being optimized for murex) does this:
// create a hdos
// write a bunch of stuff to it
byte[] myData = hdos.toByteArray();
DataSerializer.writeByteArray(myData, out);
he toByteArray allocates a new byte array and copies all the data in the hdos to it.
Then writeByteArray writes it all to "out".
We can do this instead:
if (out instanceof HeapDataOutputStream)

{ out.writeAsSerializedByteArray(hdos); }

else

{ .. do it the old way }