[GEODE-2097] Offheap persistent heapLRU regions can run out of offheap memory during recovery

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Component/s: offheap
• Assignee: Darrel Schneider
• Reporter: Darrel Schneider
• Created: 11/Nov/16 18:03
• Updated: 17/Jun/17 18:03
• Resolved: 24/Apr/17 16:03

Description

When the data for a persistent region is being recovered from the disk store the lru limit is constantly checked. If the lru limit is exceeded then value recovery will cease. But for off-heap regions this lru limit should be checking how much off-heap memory has been allocated.
During recovery the amount of heap memory is being checked for an offheap regions. So we can end up recovering too many values to off-heap and running out of off-heap memory during recovery.

The code that causes this problem is: org.apache.geode.internal.cache.lru.HeapLRUCapacityController.createLRUHelper().new AbstractEnableLRU()

{...}

.mustEvict(LRUStatistics, Region, int)

During off-heap disk store recovery the Region parameter passed to this method is "null". This causes the following heap check to be done:
if (region == null)

{ return resourceManager.getHeapMonitor().getState().isEviction(); }