[GEODE-1798] Dead code in transaction layer confusing

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: transactions
• Assignee: Unassigned
• Reporter: Darrel Schneider
• Created: 17/Aug/16 18:07
• Updated: 23/Feb/18 23:41

Description

In geode the transaction code always has a collection of "pendingCallbacks". But the code makes some special calls if this collection is null. This code should be cleaned up to only handle an existing collection.

Also BucketRegion has an implementation of invokeTXCallbacks that is wrong. If it ever is called it will cause extra events. But it should never be invoked since pendingCallbacks is never null. Instead PartitionedRegion.invokeTXCallbacks will be invoked.
So the implementation of BucketRegion invokeTXCallbacks should be changed to throw an exception. If tests find any code paths that call it they should be changed to instead call PartitionedRegion.