[GEODE-136] Fix possible NullPointerException in Gfsh's 'list regions' command's GetRegionsFunction.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.0-incubating
• Fix Version/s: 1.0.0-incubating
• Component/s: gfsh
• Labels: ApacheGeode CLI GFSH GetRegionsFunction list-regions
• Environment: GemFire Manager + Gfsh
• Assignee: Kevin Duling
• Reporter: John Blum
• Created: 17/Jul/15 20:58
• Updated: 25/Oct/16 07:17
• Resolved: 04/Oct/16 23:37

Description

The following line (#48) in the GetRegionsFunction class could possibly lead to a NPE if the regions Set is null since the regions.isEmpty() call proceeds the regions == null check.

Of course, one should argue whether Cache.rootRegions() should be returning a null Set at all rather than an empty Set if there are in fact no "root" Regions in the Geode Cache.

But then, one could also argue that this GetRegionsFunction should not be returning a null "array" if there are no "root" Regions in the Geode Cache either. It too should be returning an "empty" array.

Issue Links

• links to: GitHub Pull Request #252
• links to: GitHub Pull Request #253