[GEODE-10129] Forward module-related options when launching test subprocesses

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.15.0
• Fix Version/s: 1.15.0
• Component/s: tests
• Labels: Java17 pull-request-available
• Assignee: Dale Emery
• Reporter: Dale Emery
• Created: 16/Mar/22 17:29
• Updated: 22/Jun/22 20:46
• Resolved: 21/Mar/22 22:17

Description

Several tests and test helpers launch JVMs to run Geode code. For tests to run properly on JDK 17, that code must open or export the packages needed by the code that will run in the JVMs.

Such helpers include:

• GfshCommandRule
• ProcessManager for DUnit tests.
• ServerContainer for Jetty/Tomcat session tests.

Also, ServerLauncherDUnitTest launches JVMs via a ProcessBuilder.

A simple way to support opening and exporting the required packages is:

1. Assume that the current JVM opened and exported all required packages. (See https://issues.apache.org/jira/browse/GEODE-10128)
2. Query the -add-opens and add-exports that were used to launch the current JVM. This can be done by calling ManagementFactory.getRuntimeMXBean().getInputArguments(), then filtering the list to retain only the add-opens and -add-exports options.
3. Add those options when launching a subprocess.

It would be useful to query and perform the current JVM a single place. I propose a static method: JavaModuleHelper.getJvmModuleOptions().

Issue Links

• links to: GitHub Pull Request #7457