[GEODE-10098] TcrConnection::readMessage should not be explicitly allocating memory

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: native client
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Blake Bender
• Created: 02/Mar/22 18:23
• Updated: 08/Mar/22 17:24

Description

This method calls new to read an array of bytes, then returns it to the caller, whose responsibility is to delete it (what the heck???).  Even better, the memory is deleted in a call to TcrMessage::setData, so not even in the same class.  If this memory was a std::vector<int8_t>, we could probably take advantage of move semantics and maybe even improve performance a bit, in addition to avoiding potential leaks and weirdness...

Issue Links

• links to: GitHub Pull Request #943