[GEODE-10095] TcrConnection::readHandshakeData reads too many bytes

• Type: Bug
• Status: In Progress
• Priority: Major
• Resolution: Unresolved
• Component/s: native client
• Assignee: Matthew Reddington
• Reporter: Blake Bender
• Created: 01/Mar/22 19:15
• Updated: 05/Apr/22 22:49

Description

This method is called to read bytes from a socket, and return said data in a `std::vector<int8_t>`. For some inexplicable (inexcusable?) reason, the method always adds a 0 byte to the end of the vector, as if it were null-terminating a string. So, `readHandshakeData(1)` returns 2 bytes, `readHandshakeData(5)` returns 6 bytes, etc.

This is extremely misleading, given the name of the method and the fact that the requested number of bytes is a parameter passed in. Also, in no circumstance is this method used to actually read a string, i.e. something that may require null-termination. Please remove the extra byte from the returned vector, and if possible add a unit test to the suite that reads n bytes and asserts that the method always returns n bytes.