[GEODE-10049] Redis tests should include the entire error response message rather than just the error type

• Type: Test
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.15.0
• Fix Version/s: 1.15.0
• Component/s: redis
• Labels: pull-request-available
• Assignee: Donal Evans
• Reporter: Donal Evans
• Created: 11/Feb/22 21:49
• Updated: 22/Jun/22 20:46
• Resolved: 28/Feb/22 21:58

Description

Currently many tests look for substrings of error messages, rather than the error message as a whole. This has in the past led to cases where the Geode for Redis Module's error messages have not precisely matched those of native Redis.

For example, if the test is:

assertThatThrownBy(
        () -> jedis.hsetnx(string_key, field, "something else"))
            .isInstanceOf(JedisDataException.class)
            .hasMessageContaining("WRONGTYPE");

instead we should probably look for the full error message that native Redis puts out:

.hasMessage("WRONGTYPE Operation against a key holding the wrong kind of value")

Issue Links

• links to: GitHub Pull Request #7362