[GEODE-10011] SizeableBytes2ObjectOpenCustomHashMapWithCursorQuickCheckTest.scanWithNoModificationsDoesNotReturnDuplicates is flaky

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.15.0
• Fix Version/s: 1.15.0
• Component/s: redis
• Labels: flaky pull-request-available
• Assignee: Donal Evans
• Reporter: Donal Evans
• Created: 02/Feb/22 01:18
• Updated: 22/Jun/22 20:46
• Resolved: 02/Feb/22 16:34

Description

SizeableBytes2ObjectOpenCustomHashMapWithCursorQuickCheckTest > scanWithNoModificationsDoesNotReturnDuplicates FAILED
    java.lang.AssertionError: Property named 'scanWithNoModificationsDoesNotReturnDuplicates' failed (
    Expected size: 2 but was: 4 in:
    [176, 55, 176, 55]):
    With arguments: [[176, 55]]
    Original failure message: 
    Expected size: 2 but was: 4 in:
    [55, 202, 55, 202]
    First arguments found to also provoke a failure: [[55, 202]]
    Seeds for reproduction: [5487908098719980972]
        at org.apache.geode.redis.internal.data.collections.SizeableBytes2ObjectOpenCustomHashMapWithCursorQuickCheckTest.scanWithNoModificationsDoesNotReturnDuplicates(SizeableBytes2ObjectOpenCustomHashMapWithCursorQuickCheckTest.java:85)

        Caused by:
        java.lang.AssertionError: 
        Expected size: 2 but was: 4 in:
        [55, 202, 55, 202]
            at org.apache.geode.redis.internal.data.collections.SizeableBytes2ObjectOpenCustomHashMapWithCursorQuickCheckTest.scanWithNoModificationsDoesNotReturnDuplicates(SizeableBytes2ObjectOpenCustomHashMapWithCursorQuickCheckTest.java:85)

This failure is due to the test assuming that more than one scan is necessary to scan the entire map, but for small map sizes (the map in the failure above only has 2 keys) it's possible that the first scan will return all elements and a cursor value of 0, meaning that the second scan will also return all elements, leading to duplicate elements in the result.

Issue Links

• links to: GitHub Pull Request #7333