Commons Functor
  1. Commons Functor
  2. FUNCTOR-9

[PATCH] Make Limit and Offset Serializable

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0
    • Labels:
      None
    • Environment:

      Win7 Enterprise, jdk-1.6.0_27, Eclipse Galileo

      Description

      In org.apache.commons.functor.core all classes that are in someway a Functor implement Serializable, with exception of Limit and Offset (as pointed by E. Bourg in the mailing list). This patch marks both classes as Serializable and includes equals() and hashcode() methods.

      Notice that these changes are already covered by the test org.apache.commons.functor.BaseFunctorTest#testSerializeDeserializeThenCompare.

      Bruno P. Kinoshita

      1. FUNCTOR-9.patch
        4 kB
        Bruno P. Kinoshita

        Activity

        Bruno P. Kinoshita created issue -
        Bruno P. Kinoshita made changes -
        Field Original Value New Value
        Attachment FUNCTOR-9.patch [ 12501773 ]
        Hide
        Bruno P. Kinoshita added a comment -

        Hi all,

        I created this issue from http://markmail.org/message/ythw55yad5lrvqrj

        More specifically:

        "- Why aren't Limit and Offset serializable like the other classes in the core package?"

        However, recently in [math] there is a discussion [1] on either make everything Serializable or not.

        Maybe we could consider thinking about either making everything Serializable (as is now) or provide another mechanism for doing so or let the user handle the serialization. WDYT?

        [1] http://commons.markmail.org/message/6zi7lzqlgmfb5djb

        Show
        Bruno P. Kinoshita added a comment - Hi all, I created this issue from http://markmail.org/message/ythw55yad5lrvqrj More specifically: "- Why aren't Limit and Offset serializable like the other classes in the core package?" However, recently in [math] there is a discussion [1] on either make everything Serializable or not. Maybe we could consider thinking about either making everything Serializable (as is now) or provide another mechanism for doing so or let the user handle the serialization. WDYT? [1] http://commons.markmail.org/message/6zi7lzqlgmfb5djb
        simonetripodi committed 1344792 (3 files)
        Hide
        Simone Tripodi added a comment -

        very good, patch applied, see r1344792

        thanks and all the best!

        Show
        Simone Tripodi added a comment - very good, patch applied, see r1344792 thanks and all the best!
        Simone Tripodi made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Simone Tripodi [ simone.tripodi ]
        Fix Version/s 1.0 [ 12319504 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Simone Tripodi
            Reporter:
            Bruno P. Kinoshita
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development