Commons Functor
  1. Commons Functor
  2. FUNCTOR-15

[PATCH] Distribute tests from TestAlgorithms into several test classes under algorithm test package

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0
    • Labels:
    • Environment:

      debian lenny, eclipse indigo, sun java 6

      Description

      Several algorithms are tested in o.a.c.functor.TestAlgorithms. This test class has too many methods, and this way it's harder to include new tests or manage existing ones. We will create separate test classes for each algorithm under o.a.c.functor.algorithm, and will include generics too.

      1. FUNCTOR-15.patch
        57 kB
        Bruno P. Kinoshita

        Activity

        Hide
        Bruno P. Kinoshita added a comment -

        Patch with tests for algorithms.

        This patch also includes toString() methods in algorithms. Some algorithms needed the toString() to pass the tests (BaseFunctorTest).

        I implemented toString() in all algorithms to keep the same behavior regarding toString() in all algorithms.

        I reviewed the license headers, checkstyle issues and general formatting Hope this patch is good.

        Thanks

        Show
        Bruno P. Kinoshita added a comment - Patch with tests for algorithms. This patch also includes toString() methods in algorithms. Some algorithms needed the toString() to pass the tests (BaseFunctorTest). I implemented toString() in all algorithms to keep the same behavior regarding toString() in all algorithms. I reviewed the license headers, checkstyle issues and general formatting Hope this patch is good. Thanks
        Hide
        Simone Tripodi added a comment -

        patch applied, see r1344796

        please pay attention when adding new files: no tabs and no trailing spaces (also on empty lines)

        thanks!

        Show
        Simone Tripodi added a comment - patch applied, see r1344796 please pay attention when adding new files: no tabs and no trailing spaces (also on empty lines) thanks!
        Hide
        Bruno P. Kinoshita added a comment -

        Thanks Simo, I will pay attention to this. I believe I can configure Eclipse or maybe Checkstyle for this.

        Show
        Bruno P. Kinoshita added a comment - Thanks Simo, I will pay attention to this. I believe I can configure Eclipse or maybe Checkstyle for this.

          People

          • Assignee:
            Simone Tripodi
            Reporter:
            Bruno P. Kinoshita
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development