FtpServer
  1. FtpServer
  2. FTPSERVER-49

Specific return type for UserManager.getAllUserNames() not documented

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      UserManager.getAllUserNames() is declared as returning a Collection, but the comments do not specify that it is a collection of Strings. This is partially implied by the name of the method, but it would be helpful to explicitly specify this until the decision is made to exploit Java 1.5 generics in the source code.

        Activity

        Hide
        Niklas Gustavsson added a comment -

        I've changed the method signature so that it instead returns an array of Strings. This will make the return value strongly typed without the need for generics at this point.

        Change is rev 467470.

        Show
        Niklas Gustavsson added a comment - I've changed the method signature so that it instead returns an array of Strings. This will make the return value strongly typed without the need for generics at this point. Change is rev 467470.

          People

          • Assignee:
            Niklas Gustavsson
            Reporter:
            Clinton Foster
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development