[FTPSERVER-414] STAT / creates invalid directory listing (with Patch)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.5
• Fix Version/s: 1.0.6, 1.1.0
• Component/s: Server
• Assignee: Niklas Therning
• Reporter: Emmeran Seehuber
• Created: 27/May/11 08:57
• Updated: 31/May/11 13:29
• Resolved: 31/May/11 13:29

Description

Some ftp clients (e.g. Cyberduck on Mac OS X) use the STAT command to list directores. The reply contains an invalid status code in the last line, which causes the ftp client to ignore the last line. So the last file in the directory does not show up in the ftp client listing:

614869 [pool-3-thread-6] INFO org.apache.ftpserver.listener.nio.FtpLoggingFilter - RECEIVED: STAT /
615085 [pool-3-thread-6] INFO org.apache.ftpserver.listener.nio.FtpLoggingFilter - SENT: 200--w------ 1 [e-mail] [e-mail] 21581 Jan 1 1970 uxz.pdf
-w------ 1 [e-mail] [e-mail] 5788 Jan 1 1970 abc.pdf
-w------ 1 [e-mail] [e-mail] 415447 Jan 1 1970 def.pdf
200 -w------ 1 [e-mail] [e-mail] 822782 Jan 1 1970 xyz.pdf

I dont know if this is a bug in the ftp client. But at least the following patch to the STAT command fixes the problem for me:

diff --git a/org/apache/ftpserver/command/impl/STAT.java b/org/apache/ftpserver/command/impl/STAT.java
index 19674b2..5ca76c1 100644
— a/org/apache/ftpserver/command/impl/STAT.java
+++ b/org/apache/ftpserver/command/impl/STAT.java
@@ -77,10 +77,6 @@ public class STAT extends AbstractCommand {

String dirList = directoryLister.listFiles(parsedArg,
session.getFileSystemView(), LIST_FILE_FORMATER);
+ // DefaultFtpReply prepends the status code to the last line.
+ // This causes the STAT directory listing to loose the last directory entry in some clients
+ // e.g. Cyberduck
+ dirList += " \n";

session
.write(new DefaultFtpReply(

With this patch applied the output looks like this:

615085 [pool-3-thread-6] INFO org.apache.ftpserver.listener.nio.FtpLoggingFilter - SENT: 200--w------ 1 [e-mail] [e-mail] 21581 Jan 1 1970 uxz.pdf
-w------ 1 [e-mail] [e-mail] 5788 Jan 1 1970 abc.pdf
-w------ 1 [e-mail] [e-mail] 415447 Jan 1 1970 def.pdf
-w------ 1 [e-mail] [e-mail] 822782 Jan 1 1970 xyz.pdf
200

And know the clients work correctly.