Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.5
    • Fix Version/s: 1.0.6, 1.1.0
    • Component/s: None
    • Labels:
      None

      Description

      I'm now using MINA FtpServer for the Integration Tests of Apache mavens wagon-ftp. While upgrding from a 8 year old avalon based ftpserver jar, I figured that a unit test is broken.
      This has to do with FtpServer returning a 200 state which is imo invalid.

      According to the officla RFC http://www.faqs.org/rfcs/rfc959.html STAT may only return the following codes:

      STAT
      211, 212, 213
      450
      500, 501, 502, 421, 530

      I think returning 200 (command ok) after a STAT command is a bug.

        Activity

        Mark Struberg created issue -
        Hide
        Niklas Gustavsson added a comment -

        Fixed in rev 1128769 and 1128770, thanks for reporting!

        Show
        Niklas Gustavsson added a comment - Fixed in rev 1128769 and 1128770, thanks for reporting!
        Niklas Gustavsson made changes -
        Field Original Value New Value
        Status Open [ 1 ] Closed [ 6 ]
        Assignee Niklas Gustavsson [ niklas ]
        Fix Version/s 1.0.6 [ 12315314 ]
        Fix Version/s 1.1.0 [ 12313458 ]
        Resolution Fixed [ 1 ]
        Hide
        Niklas Gustavsson added a comment -

        Fixed to use another, incorrect reply code first. Now fixed again in rev 1129318 and 1129319.

        Show
        Niklas Gustavsson added a comment - Fixed to use another, incorrect reply code first. Now fixed again in rev 1129318 and 1129319.
        Hide
        Mark Struberg added a comment -

        Just out of curiosity, which ret code can we expect in the future?

        Show
        Mark Struberg added a comment - Just out of curiosity, which ret code can we expect in the future?
        Hide
        Niklas Gustavsson added a comment -

        Ha!

        int replyCode;
        if(file.isDirectory())

        { replyCode = FtpReply.REPLY_212_DIRECTORY_STATUS; }

        else

        { replyCode = FtpReply.REPLY_213_FILE_STATUS; }
        Show
        Niklas Gustavsson added a comment - Ha! int replyCode; if(file.isDirectory()) { replyCode = FtpReply.REPLY_212_DIRECTORY_STATUS; } else { replyCode = FtpReply.REPLY_213_FILE_STATUS; }
        Hide
        Sebb added a comment -

        Or in the case of STAT without a parameter:

        ftp> quote STAT
        211-Apache FtpServer
        Connected to 127.0.0.1
        Connected from 127.0.0.1
        Logged in as anonymous
        211 End of status.

        which agrees with the RFC

        Show
        Sebb added a comment - Or in the case of STAT without a parameter: ftp> quote STAT 211-Apache FtpServer Connected to 127.0.0.1 Connected from 127.0.0.1 Logged in as anonymous 211 End of status. which agrees with the RFC
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        1d 22h 26m 1 Niklas Gustavsson 28/May/11 21:31

          People

          • Assignee:
            Niklas Gustavsson
            Reporter:
            Mark Struberg
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development