[FTPSERVER-287] NLST: Implementation only supports listing files in working directory [patch provided]

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 1.1.0
• Fix Version/s: 1.0.2, 1.1.0
• Component/s: Core
• Environment: Fedora 10-64bit and RH 5.2-64bit, Java 1.6.0_12-64
• Assignee: Unassigned
• Reporter: Dennis Keller
• Created: 07/Apr/09 00:28
• Updated: 04/Jun/09 20:14
• Resolved: 04/Jun/09 20:13

Description

The NLST formatter, as implemented on trunk is insufficient to handle any request other than a file within in the current working directory. Some examples:

ftp> passive
Passive mode on.
ftp> nlist /directory/file.txt
227 Entering Passive Mode (127,0,0,1,179,241)
150 File status okay; about to open data connection.
file.txt
226 Closing data connection.

Other FTP servers return the following:

ftp> passive
Passive mode on.
ftp> nlist /directory/file.txt
227 Entering Passive Mode (127,0,0,1,179,241)
150 File status okay; about to open data connection.
/directory/file.txt
226 Closing data connection.

Upon investigating, I found that the formatter will not handle absolute file requests, parent directory request or non-absolute child directory requests. It does not error, it just doesn't give useful output.

I've modified the code to handle the cases that I could come up with, but there may be other situations that need to be covered. I'm not an expert on the FTP specification (but what I could find was not impressive), so there many be additional cases that need to be covered.

Please consider the attached patch, with accompanying test cases