FtpServer
  1. FtpServer
  2. FTPSERVER-262

FileSystemView.dispose() is never called

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0-M4
    • Fix Version/s: 1.0.0-RC2
    • Component/s: Ftplets
    • Labels:
      None

      Description

      The FileSystemView.dispose() function is never called.

      This method seems interesting to release critical resources such as JDBC connections, email sessions, etc.

      I think it is a good idea to call it when FtpSession closes (on DefaultFtpHandler.sessionClosed()) and maybe when user login again (because FileSystemView is related to an user).

      thx

        Activity

        Hide
        Niklas Therning added a comment -

        I can confirm that this bug exists also in the 1.0.0-RC1 code currently being in vote. Maybe a fix is needed before RC1 is released?

        Show
        Niklas Therning added a comment - I can confirm that this bug exists also in the 1.0.0-RC1 code currently being in vote. Maybe a fix is needed before RC1 is released?
        Hide
        Niklas Gustavsson added a comment -

        I think we should release RC1 as it is. But, maybe we should do a RC2 with this and FTPSERVER-119 fixed?

        Show
        Niklas Gustavsson added a comment - I think we should release RC1 as it is. But, maybe we should do a RC2 with this and FTPSERVER-119 fixed?
        Hide
        David Latorre added a comment -

        We should take into account that (I guess!) it is possible that the session be closed before the DataConnection ( so we can have a thread still writing to the filesystem).

        Show
        David Latorre added a comment - We should take into account that (I guess!) it is possible that the session be closed before the DataConnection ( so we can have a thread still writing to the filesystem).
        Hide
        Niklas Gustavsson added a comment -

        > We should take into account that (I guess!) it is possible that the session be closed before the DataConnection ( so we can have a thread still writing to the filesystem).

        That's a good point, but I think we should view it from the other side. Either we should not close the session before the data transfer is complete, or we should close the data transfer when the session closes. Keeping ongoing data transfers going without the session will lead to troubles. This is something we should have a look at, but I don't think it affects this issue.

        Show
        Niklas Gustavsson added a comment - > We should take into account that (I guess!) it is possible that the session be closed before the DataConnection ( so we can have a thread still writing to the filesystem). That's a good point, but I think we should view it from the other side. Either we should not close the session before the data transfer is complete, or we should close the data transfer when the session closes. Keeping ongoing data transfers going without the session will lead to troubles. This is something we should have a look at, but I don't think it affects this issue.
        Hide
        Niklas Gustavsson added a comment -

        Fixed in rev 734250, please verify that this fixes your issues. We now dispose when the session is closed.

        Show
        Niklas Gustavsson added a comment - Fixed in rev 734250, please verify that this fixes your issues. We now dispose when the session is closed.
        Hide
        Daniel Santos added a comment -

        rev 734250 fix my issue.

        thx

        Show
        Daniel Santos added a comment - rev 734250 fix my issue. thx

          People

          • Assignee:
            Niklas Gustavsson
            Reporter:
            Daniel Santos
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development