FtpServer
  1. FtpServer
  2. FTPSERVER-232

MFMT command always returns a 2XX reply even if the date could not be set

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0-M4
    • Fix Version/s: 1.0.0-RC1
    • Component/s: Core
    • Labels:
      None

      Description

      MFMT command always returns a 2XX reply even if the date could not be set.

      MFMT Command should return a Positive Completion Reply if and only if we are sure that the date on the file was modified. In order to fix this, we need to make use of the return value from java.io.File.setLastModified(long). We are not using the returned boolean from this method and assuming that the new date was set. Code needs to be changed in a few places to fix this. The issue can be reproduced by trying to set the date on a file that is in use. I used a .doc file, had it open in MS Word and ran the MFMT command and got the 213 reply, but the date on the file was not changed.

        Activity

        Hide
        David Latorre added a comment -

        Fix will be provided for 1.0.0-RC1.

        Show
        David Latorre added a comment - Fix will be provided for 1.0.0-RC1.
        Hide
        Niklas Gustavsson added a comment -

        Reopening so that we get the correct status

        Show
        Niklas Gustavsson added a comment - Reopening so that we get the correct status
        Hide
        Niklas Gustavsson added a comment -

        Looking at the code, this seemed fixed. Thus, I should have reopened

        Show
        Niklas Gustavsson added a comment - Looking at the code, this seemed fixed. Thus, I should have reopened

          People

          • Assignee:
            David Latorre
            Reporter:
            Sai Pullabhotla
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development