FtpServer
  1. FtpServer
  2. FTPSERVER-193

User.getAuthorities() should return a List, not an array

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0-M1, 1.0.0-M2, 1.0.0-M3
    • Fix Version/s: 1.0.0-M4
    • Component/s: None
    • Labels:
      None

      Description

      User.getAuthorities() currently return an array. Returning a List has many benefits (e.g. lazy loading, iteration) and with generics it is as strongly typed

        Activity

        Hide
        Niklas Gustavsson added a comment -

        Fixed

        svn commit "/media/big/home/svn/apache/ftpserver-trunk/core" "/media/big/home/svn/apache/ftpserver-trunk/ftplet-api" -m "User.getAuthorities() to return a List (FTPSERVER-193)
        File.listFiles() to return a List (FTPSERVER-192)" --username "ngn"
        M /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/command/impl/listing/DirectoryLister.java
        M /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/DefaultFtpServerContext.java
        M /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/filesystem/nativefs/impl/NativeFtpFile.java
        M /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/usermanager/impl/BaseUser.java
        M /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/usermanager/impl/DbUserManager.java
        M /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/usermanager/impl/PropertiesUserManager.java
        M /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/commands/impl/listing/LISTFileFormaterTest.java
        M /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/commands/impl/listing/MLSTFileFormaterTest.java
        M /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/commands/impl/listing/NLSTFileFormaterTest.java
        D /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/filesystem/nativefs/impl/FileObjectTestTemplate.java
        A /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/filesystem/nativefs/impl/FtpFileTestTemplate.java
        M /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/filesystem/nativefs/impl/NativeFileObjectTest.java
        M /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/usermanager/BaseUserTest.java
        M /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/usermanager/UserManagerTestTemplate.java
        M /media/big/home/svn/apache/ftpserver-trunk/ftplet-api/src/main/java/org/apache/ftpserver/ftplet/FtpFile.java
        M /media/big/home/svn/apache/ftpserver-trunk/ftplet-api/src/main/java/org/apache/ftpserver/ftplet/User.java
        Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/DefaultFtpServerContext.java
        Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/command/impl/listing/DirectoryLister.java
        Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/filesystem/nativefs/impl/NativeFtpFile.java
        Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/usermanager/impl/BaseUser.java
        Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/usermanager/impl/DbUserManager.java
        Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/usermanager/impl/PropertiesUserManager.java
        Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/commands/impl/listing/LISTFileFormaterTest.java
        Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/commands/impl/listing/MLSTFileFormaterTest.java
        Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/commands/impl/listing/NLSTFileFormaterTest.java
        Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/filesystem/nativefs/impl/FtpFileTestTemplate.java
        Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/filesystem/nativefs/impl/NativeFileObjectTest.java
        Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/usermanager/BaseUserTest.java
        Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/usermanager/UserManagerTestTemplate.java
        Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/ftplet-api/src/main/java/org/apache/ftpserver/ftplet/FtpFile.java
        Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/ftplet-api/src/main/java/org/apache/ftpserver/ftplet/User.java
        Committed revision 703875

        Show
        Niklas Gustavsson added a comment - Fixed svn commit "/media/big/home/svn/apache/ftpserver-trunk/core" "/media/big/home/svn/apache/ftpserver-trunk/ftplet-api" -m "User.getAuthorities() to return a List ( FTPSERVER-193 ) File.listFiles() to return a List ( FTPSERVER-192 )" --username "ngn" M /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/command/impl/listing/DirectoryLister.java M /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/DefaultFtpServerContext.java M /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/filesystem/nativefs/impl/NativeFtpFile.java M /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/usermanager/impl/BaseUser.java M /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/usermanager/impl/DbUserManager.java M /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/usermanager/impl/PropertiesUserManager.java M /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/commands/impl/listing/LISTFileFormaterTest.java M /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/commands/impl/listing/MLSTFileFormaterTest.java M /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/commands/impl/listing/NLSTFileFormaterTest.java D /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/filesystem/nativefs/impl/FileObjectTestTemplate.java A /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/filesystem/nativefs/impl/FtpFileTestTemplate.java M /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/filesystem/nativefs/impl/NativeFileObjectTest.java M /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/usermanager/BaseUserTest.java M /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/usermanager/UserManagerTestTemplate.java M /media/big/home/svn/apache/ftpserver-trunk/ftplet-api/src/main/java/org/apache/ftpserver/ftplet/FtpFile.java M /media/big/home/svn/apache/ftpserver-trunk/ftplet-api/src/main/java/org/apache/ftpserver/ftplet/User.java Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/DefaultFtpServerContext.java Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/command/impl/listing/DirectoryLister.java Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/filesystem/nativefs/impl/NativeFtpFile.java Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/usermanager/impl/BaseUser.java Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/usermanager/impl/DbUserManager.java Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/usermanager/impl/PropertiesUserManager.java Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/commands/impl/listing/LISTFileFormaterTest.java Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/commands/impl/listing/MLSTFileFormaterTest.java Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/commands/impl/listing/NLSTFileFormaterTest.java Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/filesystem/nativefs/impl/FtpFileTestTemplate.java Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/filesystem/nativefs/impl/NativeFileObjectTest.java Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/usermanager/BaseUserTest.java Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/usermanager/UserManagerTestTemplate.java Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/ftplet-api/src/main/java/org/apache/ftpserver/ftplet/FtpFile.java Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/ftplet-api/src/main/java/org/apache/ftpserver/ftplet/User.java Committed revision 703875

          People

          • Assignee:
            Niklas Gustavsson
            Reporter:
            Niklas Gustavsson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development