[FTPSERVER-191] FileSystemView: The methods for changing and getting the current working directory have non similar names

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.0-M1, 1.0.0-M2, 1.0.0-M3
• Fix Version/s: 1.0.0-M4
• Component/s: Core, Ftplets
• Assignee: Niklas Therning
• Reporter: Andrea Francia
• Created: 12/Oct/08 17:34
• Updated: 12/Oct/08 21:12
• Resolved: 12/Oct/08 21:12

Description

The following snippet shows some methods names of current FileSystemView interface:

public interface FileSystemView {

/**

• Get user current directory.
  */
  FtpFile getCurrentDirectory() throws FtpException;

/**

• Change directory.
  */
  boolean changeDirectory(String dir) throws FtpException;
  }

If the methods changeDirectory() and getCurrentDirectory() refers the same thing I think they should have similar names. For example:

• changeFoo()
• getFoo()

The word 'current' is not useful because in that enviroment is obvious that is the current one.
The rfc959 uses the following terminolog for the relevant commands:

• CHANGE WORKING DIRECTORY (CWD)
• PRINT WORKING DIRECTORY (PWD)

So I think the word to use is 'working'.

I think the methods should be renamed in:

• boolean changeWorkingDirectory(String dir) { ... }
  * FtpFile getWorkingDirectory() { ... }