FtpServer
  1. FtpServer
  2. FTPSERVER-182

Method names of FileObject#getFullName() and FileObject#getShorName does not use standard nomenclature

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0-M1, 1.0.0-M2, 1.0.0-M3
    • Fix Version/s: 1.0.0-M4
    • Component/s: None
    • Labels:
      None

      Description

      I don't know that this issue could be solved, due the fact that is part of the API and there is some people already using the library.

      /**

      • Get the fully qualified name.
        */
        String getFullName();

      /**

      • Get the file short name.
        */
        String getShortName();

      The terms "full name" or "short name" are not used in none standard library that I know.

      For the former the terms used are "path", "absolute path", "full path"
      See

      For the latter the used are "basename" or "name". The term shorname recall the short name of the vfat file system.

      Usually "fully qualified names" terminology is not used in about file paths.

      I propose:

      /**

      • Get the full path from the base directory of the FileSystemView.
      • @return a path where the path separator is '/' (even if O.S. uses another character as path separator).
        */
        String getFullPath();

      /**

      • Get the file name (basename) of the file
      • @return the last part of the file path (the part after the last '/').
        */
        String getName();

        Activity

        Hide
        Niklas Gustavsson added a comment -

        Fixed (using getAbsolutePath and getName) in rev 703878. Thanks!

        Show
        Niklas Gustavsson added a comment - Fixed (using getAbsolutePath and getName) in rev 703878. Thanks!

          People

          • Assignee:
            Niklas Gustavsson
            Reporter:
            Andrea Francia
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development