[FTPSERVER-177] Passive port ranges are not properly released

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Fix Version/s: 1.0.0-M4
• Assignee: Niklas Therning
• Reporter: Kevin Conaway
• Created: 11/Sep/08 19:05
• Updated: 12/Sep/08 12:25
• Resolved: 11/Sep/08 20:56

Description

When using a range of passive ports, the passive ports are not appropriately released. This leads to a deadlock after all the ports in the range have been filled up.

I believe that this is because the QUIT command should be calling session.getDataConnection().closeDataConnection(); which in turn calls session.getListener().getDataConnectionConfiguration().releasePassivePort(<portNumber>);

In the attached patch, I've modified the org.apache.ftpserver.clienttests.PasvTest testcase to use a 1-value range of passive ports which exposes this issue. I've also added the session.getDataConnection().closeDataConnection() to the QUIT command