[FREEMARKER-19] 2.3.24 calculates column number with tab size 1 instead of 8

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.24-incubating
• Fix Version/s: 2.3.25-incubating
• Assignee: Dániel Dékány
• Reporter: Dániel Dékány
• Created: 09/Apr/16 21:07
• Updated: 26/Jun/16 18:55
• Resolved: 10/Apr/16 18:45

Description

This change has slipped in with the JavaCC update in 2.3.24 (JavaCC has changed the default tab size from 8 to 1). It affects the column numbers shown in error messages, not the template output. While tab size 1 is better than 8 for most use cases (such as for placing error markers in IDE-s), it was 8 so far, so this change is not backward compatible, and the default has to be changed back to 8. On the same time, we should add a tab_size configuration setting. After all, we don't know what the tab size is in an application. Also that allows setting it to 1 (that's often practical).