Uploaded image for project: 'Apache Freemarker'
  1. Apache Freemarker
  2. FREEMARKER-19

2.3.24 calculates column number with tab size 1 instead of 8

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.24-incubating
    • Fix Version/s: 2.3.25-incubating
    • Component/s: None
    • Labels:
      None

      Description

      This change has slipped in with the JavaCC update in 2.3.24 (JavaCC has changed the default tab size from 8 to 1). It affects the column numbers shown in error messages, not the template output. While tab size 1 is better than 8 for most use cases (such as for placing error markers in IDE-s), it was 8 so far, so this change is not backward compatible, and the default has to be changed back to 8. On the same time, we should add a tab_size configuration setting. After all, we don't know what the tab size is in an application. Also that allows setting it to 1 (that's often practical).

        Attachments

          Activity

            People

            • Assignee:
              ddekany Dániel Dékány
              Reporter:
              ddekany Dániel Dékány
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: