Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 0.8
    • Fix Version/s: None
    • Labels:
      None

      Description

      The i18n functionality uses the LocaleAction and LocaleMatcher components, but instead of being configured in a single place, there are several instances of these components' configurations.

      The LocaleAction, in particular, is configured in i18n.xmap, forrest.xmap, tabs.xmap. Currently it uses default settings so it's not really a problem, but becomes one if people want to change the settings.

      Also, the i18n transformer sometimes takes its locale from {request:locale} and sometimes from an enclosing LocaleAction. I think this explains the discrepancies observed in some cases, for example having tabs in one language and the content in another.

      I'm going to commit changes that move all the LocaleAction and LocaleMatcher configuration to the main sitemap, and always use the LocaleAction to provide the locale for the i18n transformer.

        Activity

        Hide
        bdelacretaz Bertrand Delacretaz added a comment -
        I have committed the changes described above, and completed the i18n configuration of the fresh-site, including fr and de versions of the index.xml page as examples.
        Show
        bdelacretaz Bertrand Delacretaz added a comment - I have committed the changes described above, and completed the i18n configuration of the fresh-site, including fr and de versions of the index.xml page as examples.
        Hide
        bdelacretaz Bertrand Delacretaz added a comment -
        The result is that switching languages works more consistently, i.e. on a "forrest seed" fresh site:

          index.html
          index.html?locale=de
          index.html?locale=fr

        show the translated versions of the content, tabs and menus.

        Should also with browser headers detection, but it is disabled by default (see FOR-888).

        I have set project.i18n=true in fresh-site to make these examples visible without configuration. This shouldn't be a problem as the locale must now be specified explicitely, so the change should be invisible to users who don't care about i18n.


        Show
        bdelacretaz Bertrand Delacretaz added a comment - The result is that switching languages works more consistently, i.e. on a "forrest seed" fresh site:   index.html   index.html?locale=de   index.html?locale=fr show the translated versions of the content, tabs and menus. Should also with browser headers detection, but it is disabled by default (see FOR-888 ). I have set project.i18n=true in fresh-site to make these examples visible without configuration. This shouldn't be a problem as the locale must now be specified explicitely, so the change should be invisible to users who don't care about i18n.

          People

          • Assignee:
            Unassigned
            Reporter:
            bdelacretaz Bertrand Delacretaz
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development