Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.6
    • Fix Version/s: 0.6
    • Component/s: Skins (general issues)
    • Labels:
      None

      Description

      Now that content is editable in the src directory we need to have skins editable their too.

        Activity

        Hide
        Ross Gardler added a comment -
        The problem appears to be that forrest.home is used to set the path to the stylesheets in cocoon.xconf.
        Show
        Ross Gardler added a comment - The problem appears to be that forrest.home is used to set the path to the stylesheets in cocoon.xconf.
        Hide
        Ross Gardler added a comment -
        Looking good, but we have introduced a bug. I decided to test on a different machine from my development machine by installing the WAR there.

        Somewhere along the line a path to project home is fixed, this results in the following error:

        Internal Server Error

        Message: null

        Description: No details available.

        Sender: org.apache.cocoon.servlet.CocoonServlet

        Source: Cocoon Servlet

        request-uri

        /ECommerceCourse/index.html

        Request URI

        index.html

        cause

        /home/username/openSource/xml-forrest/build/dist/shbat/bin/../context/skins/saafe-course/xslt/html/site2xhtml.xsl (No such file or directory)

        The important thing is this last path, it should not be looking in /home/username..., but in the current webapp context.

        I don't have much time to look into this now, but any hints as to what the problem should help me out on Friday (which is the soonest I can look at it).

        Show
        Ross Gardler added a comment - Looking good, but we have introduced a bug. I decided to test on a different machine from my development machine by installing the WAR there. Somewhere along the line a path to project home is fixed, this results in the following error: Internal Server Error Message: null Description: No details available. Sender: org.apache.cocoon.servlet.CocoonServlet Source: Cocoon Servlet request-uri /ECommerceCourse/index.html Request URI index.html cause /home/username/openSource/xml-forrest/build/dist/shbat/bin/../context/skins/saafe-course/xslt/html/site2xhtml.xsl (No such file or directory) The important thing is this last path, it should not be looking in /home/username..., but in the current webapp context. I don't have much time to look into this now, but any hints as to what the problem should help me out on Friday (which is the soonest I can look at it).
        Hide
        Nicola Ken Barozzi added a comment -
        Applied with some changes and fixed also the breadcrumb bug that it would have introduced.

        Please crosscheck.
        Show
        Nicola Ken Barozzi added a comment - Applied with some changes and fixed also the breadcrumb bug that it would have introduced. Please crosscheck.
        Hide
        Nicola Ken Barozzi added a comment -
        Almost there, still need to fix the breadcrumb issue.
        Show
        Nicola Ken Barozzi added a comment - Almost there, still need to fix the breadcrumb issue.
        Hide
        Nicola Ken Barozzi added a comment -
        Have tried the patch with some changes (I have to keep some copying for when we use the CLI as CSS files are not linked), and it's quite nice, except for a bug: the stylesheets fail to find the project skinconf.

        Unless I have made a mistake in applying it, it seems that the $config-file param is set in the skins/common/site2html.xsl file as a relative url. Since the skin is now in the forrest home, the path is invalid.

        It should instead be set in the sitemap to point to the project skinconf.

        NOTE: It's late now, if it were day I would have tried it myself, but I prefer to sleep now and record this for now.
        Show
        Nicola Ken Barozzi added a comment - Have tried the patch with some changes (I have to keep some copying for when we use the CLI as CSS files are not linked), and it's quite nice, except for a bug: the stylesheets fail to find the project skinconf. Unless I have made a mistake in applying it, it seems that the $config-file param is set in the skins/common/site2html.xsl file as a relative url. Since the skin is now in the forrest home, the path is invalid. It should instead be set in the sitemap to point to the project skinconf. NOTE: It's late now, if it were day I would have tried it myself, but I prefer to sleep now and record this for now.
        Hide
        Ross Gardler added a comment -
        Patch that solves this issue *but* introduces a new problem. Since JS files are no longer copied over by ANT the skinconfig values for the breadcrumb trail are not set in the breadcrumb script.

        This patch gets around the problem by commenting out the relevent section of code. This results in a breadcrumb trail that works but does not show the settings in the skinconf. This can be got around by having the stylesheets put the values into meta tags (or hidden form fields?) in the HTML and having the script read from them in it's initialisation process. There may be other solutions too. I've not implemented one because I don't use that feature of breadcrumbs ;-)
        Show
        Ross Gardler added a comment - Patch that solves this issue *but* introduces a new problem. Since JS files are no longer copied over by ANT the skinconfig values for the breadcrumb trail are not set in the breadcrumb script. This patch gets around the problem by commenting out the relevent section of code. This results in a breadcrumb trail that works but does not show the settings in the skinconf. This can be got around by having the stylesheets put the values into meta tags (or hidden form fields?) in the HTML and having the script read from them in it's initialisation process. There may be other solutions too. I've not implemented one because I don't use that feature of breadcrumbs ;-)

          People

          • Assignee:
            Nicola Ken Barozzi
            Reporter:
            Ross Gardler
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development