Uploaded image for project: 'Forrest'
  1. Forrest
  2. FOR-771

bin/forrest: Incomplete symlink resolution and incorrect argument passing

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.7, 0.8
    • Fix Version/s: 0.8
    • Component/s: Core operations
    • Labels:
      None
    • Urgency:
      Normal
    • Other Info:
      Patch available

      Description

      Issues in bin/forrest:
      1. The symlink resolution does not handle chained symlinks
      2. The value assigned to FORREST_HOME is not canonical
      3. Command line arguments are passed to ant as $@ instead of "$@"

      The attached patch bin_forrest.diff fixes these issues and is against SVN HEAD (rev. 232917). The symlink resolution code is less verbose than before (borrowed from the Ant launch script).

        Activity

        Hide
        rgardler Ross Gardler added a comment -
        Patch applied - thanks.

        This only affects the .sh scri[t for Forrest. Is there a need to update the .bat script in a similar way?

        Any windows people out there please have a look at this patch and make necessary changes or close this issue.
        Show
        rgardler Ross Gardler added a comment - Patch applied - thanks. This only affects the .sh scri[t for Forrest. Is there a need to update the .bat script in a similar way? Any windows people out there please have a look at this patch and make necessary changes or close this issue.

          People

          • Assignee:
            rgardler Ross Gardler
            Reporter:
            rcalmbac Richard Calmbach
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development