Forrest
  1. Forrest
  2. FOR-736

LocationMap fails to find files with embedded spaces in the URL

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8
    • Fix Version/s: 0.8
    • Component/s: Locationmap
    • Labels:
      None
    • Environment:
      Suspect all environments, but tested in Forrest r345489 & jdk1.5.0_05 running on WinXP

      Description

      The LocationMap fails to find files that have spaces embedded in the URL. For instance, in my case, it will find

      http://10.222.12.456/open/System%20Identification%20Report.pdf

      But fails to find it as

      http://10.222.12.456/open/System Identification Report.pdf

      Incidentally, for information on resolving to PDF files please see http://www.mail-archive.com/user@forrest.apache.org/msg01212.html

        Issue Links

          Activity

          Hide
          Tim Williams added a comment -
          Can someone explain a bit more about this? Spaces that aren't URI encoded aren't a valid URL, right? So why should it worry about them? Maybe I'm missing the issue...
          Show
          Tim Williams added a comment - Can someone explain a bit more about this? Spaces that aren't URI encoded aren't a valid URL, right? So why should it worry about them? Maybe I'm missing the issue...
          Hide
          Ross Gardler added a comment -
          My own thinking is that it is a convenience if we allow people ot enter the URL without the URL encoding. It is much easier to type a space than %20

          The same would go for other characters that need encoding. It's simply a case of passing the value through a utility method before returning it as a lcoation isn't it?
          Show
          Ross Gardler added a comment - My own thinking is that it is a convenience if we allow people ot enter the URL without the URL encoding. It is much easier to type a space than %20 The same would go for other characters that need encoding. It's simply a case of passing the value through a utility method before returning it as a lcoation isn't it?
          Hide
          Ross Gardler added a comment -
          http: urls are now URL Encoded before being returned. This should solve the problem, do we need to add any other protocols to the URL encoded list?
          Show
          Ross Gardler added a comment - http: urls are now URL Encoded before being returned. This should solve the problem, do we need to add any other protocols to the URL encoded list?

            People

            • Assignee:
              Ross Gardler
              Reporter:
              Greg Jenci
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development