Uploaded image for project: 'Forrest'
  1. Forrest
  2. FOR-430

FO output ignores color settings defined by skinconf.xml

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.7
    • Fix Version/s: 0.7
    • Component/s: Skins (general issues)
    • Labels:
      None
    • Environment:
      Tested on Debian Sarge with Linux 2.6.8 and JDK 1.4.2_01

      Description

      When using FO output, Forrest ignores color settings defined in skinconf.xml. This is due to the fact that the document2fo.xsl stylesheet (in the "common" skin) uses hard-coded color values, rather than checking skinconf.xml for the user's own color settings.

        Activity

        Hide
        f.g.haas Florian G. Haas added a comment -
        This patch changes the following things in document2fo.xsl:
        * Uses skinconf.xml to determine background and border color for notes, warnings, and fixmes;
        * Uses skinconf.xml to determine background and border color for table cells (headers and data);
        * Honors headings type set in skinconf.xml (clean|underlined|boxed) and colors headings accordingly;
        * Uses skinconf.xml to determine font color for links.

        In addition, this patch extends the "link" template to also apply to the "fork", "jump", and "a" elements.
        Show
        f.g.haas Florian G. Haas added a comment - This patch changes the following things in document2fo.xsl: * Uses skinconf.xml to determine background and border color for notes, warnings, and fixmes; * Uses skinconf.xml to determine background and border color for table cells (headers and data); * Honors headings type set in skinconf.xml (clean|underlined|boxed) and colors headings accordingly; * Uses skinconf.xml to determine font color for links. In addition, this patch extends the "link" template to also apply to the "fork", "jump", and "a" elements.
        Hide
        josch Johannes Schaefer added a comment -
        It would be very nice to have this in forrest. The excel-plugin displays background colors for cells with color content (#aabbcc) in HTML, so this would work for PDF, too.
        Show
        josch Johannes Schaefer added a comment - It would be very nice to have this in forrest. The excel-plugin displays background colors for cells with color content (#aabbcc) in HTML, so this would work for PDF, too.
        Hide
        f.g.haas Florian G. Haas added a comment -
        Sorry to disappoint you Johannes, but I'm afraid that's not quite what this patch does. Unlike the Excel plugin -- which uses information from the *source document* to determine the background color for table cells --, this patch merely applies configuration settings made in *skinconf.xml* to the XML-to-FO transformation process.

        Apologies to anyone I may have confused by my patch description.
        Show
        f.g.haas Florian G. Haas added a comment - Sorry to disappoint you Johannes, but I'm afraid that's not quite what this patch does. Unlike the Excel plugin -- which uses information from the *source document* to determine the background color for table cells --, this patch merely applies configuration settings made in *skinconf.xml* to the XML-to-FO transformation process. Apologies to anyone I may have confused by my patch description.
        Hide
        rgardler Ross Gardler added a comment -
        Applied. Sorry it took so long.
        Show
        rgardler Ross Gardler added a comment - Applied. Sorry it took so long.

          People

          • Assignee:
            Unassigned
            Reporter:
            f.g.haas Florian G. Haas
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development