Forrest
  1. Forrest
  2. FOR-251

start script for UNIX bin/forrest should not be bash-specific

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.6
    • Fix Version/s: 0.6
    • Component/s: Core operations
    • Labels:
      None

      Description

      There are some commands in the bin/forrest script that are specific to the bash shell. On most systems the default /bin/sh is actually bash. However, not so on one significant OS. We should be neutral.

      As a workaround the script has been set to be /bin/bash

        Activity

        Hide
        Dave Brondsema added a comment -
        the only bash-specific part is that of substitution when trying to read a symlink.

        if FORREST_HOME is set, you can run the script as-is with the solaris 'sh' shell.
        Show
        Dave Brondsema added a comment - the only bash-specific part is that of substitution when trying to read a symlink. if FORREST_HOME is set, you can run the script as-is with the solaris 'sh' shell.
        Hide
        David Crossley added a comment -
        Before this, we just gave them an error message if they had not set $FORREST_HOME like the nice instructions showed them. What is the advantage in trying to guess it for them? It seems to just introduce compatibility problems.
        Show
        David Crossley added a comment - Before this, we just gave them an error message if they had not set $FORREST_HOME like the nice instructions showed them. What is the advantage in trying to guess it for them? It seems to just introduce compatibility problems.
        Hide
        Dave Brondsema added a comment -
        I would like forrest to work like a "normal" unix application app in unix. And it's one less thing for the user to do (and to mess up).

        I think it's pretty rare for a system not to have bash installed. And even if they don't we can have a FAQ for the simple workaround of running it with 'sh' and setting FORREST_HOME
        Show
        Dave Brondsema added a comment - I would like forrest to work like a "normal" unix application app in unix. And it's one less thing for the user to do (and to mess up). I think it's pretty rare for a system not to have bash installed. And even if they don't we can have a FAQ for the simple workaround of running it with 'sh' and setting FORREST_HOME
        Hide
        David Crossley added a comment -
        I just reverted the shell invocation line to be /bin/sh
        Users should follow the build instructions and set FORREST_HOME.
        Show
        David Crossley added a comment - I just reverted the shell invocation line to be /bin/sh Users should follow the build instructions and set FORREST_HOME.
        Hide
        Rick Tessner added a comment -
        If a symlink to forrest is created and the symlink is a relative path, the determination of FORREST_HOME fails. It does work correctly if the symlink is an absolute path.
        Show
        Rick Tessner added a comment - If a symlink to forrest is created and the symlink is a relative path, the determination of FORREST_HOME fails. It does work correctly if the symlink is an absolute path.
        Hide
        Rick Tessner added a comment -
        This patch to src/core/bin/forrest does two things:

        1. The determination of FORREST_HOME works correctly if the symlink to forrest is a relative pathname.
        2. Removes the bash specific bits and replaces it with code that will work under the Bourne Shell.
        Show
        Rick Tessner added a comment - This patch to src/core/bin/forrest does two things: 1. The determination of FORREST_HOME works correctly if the symlink to forrest is a relative pathname. 2. Removes the bash specific bits and replaces it with code that will work under the Bourne Shell.
        Hide
        David Crossley added a comment -
        Thanks, applied and closed.
        Show
        David Crossley added a comment - Thanks, applied and closed.

          People

          • Assignee:
            Unassigned
            Reporter:
            David Crossley
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development