Forrest
  1. Forrest
  2. FOR-236

better sDocBook support and feedback link

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.6
    • Fix Version/s: 0.6
    • Component/s: Core operations
    • Labels:
      None
    • Environment:
      any

      Description

      Added sDocBook support for Note-Title tag
      Added feedback link in page footer
      See attached patches.

        Activity

        Hide
        David Crossley added a comment -
        Thanks. Merged your changes with the work that Thorsten had already done on the "pelt" skin.

        I noticed that your patch was trying to do tricks to hide whitespace in element attributes. Use <xsl:text> for that and normalize-space().

        With your patch, you cannot hack it to remove extraneous stuff. That just corrupts the diff. If you have other edits in a file, then copy it to one side, remove extra stuff from the main file, test it, then do 'svn diff site2xhtml.xsl > patch.txt'.
        Show
        David Crossley added a comment - Thanks. Merged your changes with the work that Thorsten had already done on the "pelt" skin. I noticed that your patch was trying to do tricks to hide whitespace in element attributes. Use <xsl:text> for that and normalize-space(). With your patch, you cannot hack it to remove extraneous stuff. That just corrupts the diff. If you have other edits in a file, then copy it to one side, remove extra stuff from the main file, test it, then do 'svn diff site2xhtml.xsl > patch.txt'.
        Hide
        Johannes Schaefer added a comment -
        The file feedback-mail.patch contains the changes to put the feedback-link into the footer. Now optional.
        Sorry, I had to edit the patch-file manually since there were
        some changes that should not go into this patch (esp. in skinconf.xml :-)
        Show
        Johannes Schaefer added a comment - The file feedback-mail.patch contains the changes to put the feedback-link into the footer. Now optional. Sorry, I had to edit the patch-file manually since there were some changes that should not go into this patch (esp. in skinconf.xml :-)
        Hide
        David Crossley added a comment -
        The Apache xdocs document DTD (which is the intermediate format) does not have a <title> element as a child of <note> ... http://forrest.apache.org/docs/document-v13.dtdx.html#note

        You may need to investigate the src/core/context/resources/stylesheets/docbook2document.xsl
        where you might be able to extract the note-title from the DocBook document as the first text content in the xdocs <note> element.

        The "feedback" patch is almost okay. I see that you have made it optional in skinconf.xml and the DTD. However your stylesheet patch is always applying it. This would need to be always optional.

        Thanks for the effort, but we cannot apply this patch in its current state. Also please address separate issues as separate patches.
        Show
        David Crossley added a comment - The Apache xdocs document DTD (which is the intermediate format) does not have a <title> element as a child of <note> ... http://forrest.apache.org/docs/document-v13.dtdx.html#note You may need to investigate the src/core/context/resources/stylesheets/docbook2document.xsl where you might be able to extract the note-title from the DocBook document as the first text content in the xdocs <note> element. The "feedback" patch is almost okay. I see that you have made it optional in skinconf.xml and the DTD. However your stylesheet patch is always applying it. This would need to be always optional. Thanks for the effort, but we cannot apply this patch in its current state. Also please address separate issues as separate patches.
        Hide
        Johannes Schaefer added a comment -
        Added the feedback link to Book-Tab skin
        which overrides the common stylesheets.
        Might be good to add the changes there
        as well.
        Show
        Johannes Schaefer added a comment - Added the feedback link to Book-Tab skin which overrides the common stylesheets. Might be good to add the changes there as well.

          People

          • Assignee:
            Unassigned
            Reporter:
            Johannes Schaefer
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development