Forrest
  1. Forrest
  2. FOR-174

Have @class attribute in DTD for every tag

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.6
    • Fix Version/s: 0.6
    • Component/s: Core operations
    • Labels:
      None

      Description

      Add @class attribute to all tags so that the extra-css section in the skinconf can be put to good use.

        Activity

        Hide
        David Crossley added a comment -
        Many thanks to Rick. Again applying your patches is joyful. Thanks for the comprehensive list of changes. That really helps the job of the committer.

        Is there anything else that we should notify in the status.xml/changes?
        Show
        David Crossley added a comment - Many thanks to Rick. Again applying your patches is joyful. Thanks for the comprehensive list of changes. That really helps the job of the committer. Is there anything else that we should notify in the status.xml/changes?
        Hide
        Rick Tessner added a comment -
        Hi all,
                                                                                        
        I've finally had a chance to put a new patch together for J174. This patch replaces the previously uploaded attachments: forrest-j174.patch and forrest-j174.zip.
                                                                                        
        The next two files uploaded are changes based on the discussions on the dev@forrest list
                                                                                        
          http://marc.theaimsgroup.com/?l=forrest-dev&m=108741074104198&w=2
                                                                                        
        I'll be uploading two files:
                                                                                        
          j174-r22915.patch
          j174-r22915.zip
                                                                                        
                    - oOo -
                                                                                        
        j174-r22915.patch (the "svn diff") contains the following changes:
                                                                                        
          src/core/context/skins/common/xslt/fo/document2fo.xsl
          ===================================================================
                                                                                        
            Added a template for p[@class='quote'] to handle quoted paragraphs in PDF.
                                                                                        
          src/core/context/forrest.xmap
          ===================================================================
                                                                                        
            Added <sourcetype> and <map:when> elements for todo V1.3, changes V1.3, howto V1.3 todo V2.0, changes V2.0, howto V2.0 and document V2.0.
                                                                                        
          src/core/context/sitemap.xmap
          ===================================================================
                                                                                        
            Changed the <doctype-public> and <doctype-system> elements for the "xml-document" serializer to V1.3 instead of V1.2
                                                                                        
          src/core/context/resources/schema/catalog.xcat
          src/core/context/resources/schema/catalog
          ===================================================================
                                                                                        
            Added identifiers for all the V1.3 and V2.0 dtds / mods
                                                                                        
          src/core/context/resources/stylesheets/openoffice-writer2forrest.xsl
          ===================================================================
                                                                                        
            Changed <xsl:output> doctype-public and doctype-system attributes to point to V1.3
                                                                                        
          src/core/context/faq.xmap
          ===================================================================
                                                                                        
            Added <sourcetype> and <map:when> elements for FAQ V1.3 and V2.0
                                                                                        
          src/core/fresh-site/src/documentation/skinconf.xml
          ===================================================================
                                                                                        
            Added sample <extra-css> to handle a 'quote' class on <p> elements. Mirrors the change done for the common/xslt/fo/document2fo.xsl for PDF.
                                                                                        
          src/core/fresh-site/src/documentation/content/xdocs/samples/sample.xml
          ===================================================================
                                                                                        
            Changed <!DOCTYPE ...> to use Document V1.3 and added a sample paragraph, <p>, with the 'quote' class.
                                                                                        
          src/core/fresh-site/src/documentation/content/xdocs/samples/sample2.xml
          src/core/fresh-site/src/documentation/content/xdocs/samples/index.xml
          src/core/fresh-site/src/documentation/content/xdocs/samples/subdir/index.xml
          src/core/fresh-site/src/documentation/content/xdocs/samples/ascii-art.xml
          src/core/fresh-site/src/documentation/content/xdocs/index.xml
          ===================================================================
                                                                                        
            Changed <!DOCTYPE ...> to use Document V1.3
                                                                                        
          src/core/fresh-site/src/documentation/content/xdocs/samples/faq.xml
          ===================================================================
                                                                                        
            Changed <!DOCTYPE ...> to use FAQ V1.3
                                                                                        
          build.xml
          ===================================================================
                                                                                        
            Added <include> elements for the new V1.3 and V2.0 dtds
                                                                                        
                    - oOo -
                                                                                        
        j174-r22915.zip contains the following net new additions
                                                                                        
          src/core/context/resources/schema/dtd/howto-v13.dtd
          src/core/context/resources/schema/dtd/faq-v13.dtd
          src/core/context/resources/schema/dtd/document-v13.dtd
          src/core/context/resources/schema/dtd/v20/
          src/core/context/resources/schema/dtd/v20/todo-v20.dtd
          src/core/context/resources/schema/dtd/v20/todo-v20.mod
          src/core/context/resources/schema/dtd/v20/howto-v20.dtd
          src/core/context/resources/schema/dtd/v20/changes-v20.dtd
          src/core/context/resources/schema/dtd/v20/changes-v20.mod
          src/core/context/resources/schema/dtd/v20/document-v20.dtd
          src/core/context/resources/schema/dtd/v20/document-v20.mod
          src/core/context/resources/schema/dtd/v20/faq-v20.dtd
          src/core/context/resources/schema/dtd/v20/faq-v20.mod
          src/core/context/resources/schema/dtd/todo-v13.dtd
          src/core/context/resources/schema/dtd/changes-v13.dtd
          src/core/context/resources/schema/dtd/document-v13.mod
          src/core/context/resources/stylesheets/docv20todocv13.xsl
          src/core/context/resources/stylesheets/faqv20tofaqv13.xsl
        Show
        Rick Tessner added a comment - Hi all,                                                                                  I've finally had a chance to put a new patch together for J174. This patch replaces the previously uploaded attachments: forrest-j174.patch and forrest-j174.zip.                                                                                  The next two files uploaded are changes based on the discussions on the dev@forrest list                                                                                     http://marc.theaimsgroup.com/?l=forrest-dev&m=108741074104198&w=2                                                                                  I'll be uploading two files:                                                                                    j174-r22915.patch   j174-r22915.zip                                                                                              - oOo -                                                                                  j174-r22915.patch (the "svn diff") contains the following changes:                                                                                    src/core/context/skins/common/xslt/fo/document2fo.xsl   ===================================================================                                                                                      Added a template for p[@class='quote'] to handle quoted paragraphs in PDF.                                                                                    src/core/context/forrest.xmap   ===================================================================                                                                                      Added <sourcetype> and <map:when> elements for todo V1.3, changes V1.3, howto V1.3 todo V2.0, changes V2.0, howto V2.0 and document V2.0.                                                                                    src/core/context/sitemap.xmap   ===================================================================                                                                                      Changed the <doctype-public> and <doctype-system> elements for the "xml-document" serializer to V1.3 instead of V1.2                                                                                    src/core/context/resources/schema/catalog.xcat   src/core/context/resources/schema/catalog   ===================================================================                                                                                      Added identifiers for all the V1.3 and V2.0 dtds / mods                                                                                    src/core/context/resources/stylesheets/openoffice-writer2forrest.xsl   ===================================================================                                                                                      Changed <xsl:output> doctype-public and doctype-system attributes to point to V1.3                                                                                    src/core/context/faq.xmap   ===================================================================                                                                                      Added <sourcetype> and <map:when> elements for FAQ V1.3 and V2.0                                                                                    src/core/fresh-site/src/documentation/skinconf.xml   ===================================================================                                                                                      Added sample <extra-css> to handle a 'quote' class on <p> elements. Mirrors the change done for the common/xslt/fo/document2fo.xsl for PDF.                                                                                    src/core/fresh-site/src/documentation/content/xdocs/samples/sample.xml   ===================================================================                                                                                      Changed <!DOCTYPE ...> to use Document V1.3 and added a sample paragraph, <p>, with the 'quote' class.                                                                                    src/core/fresh-site/src/documentation/content/xdocs/samples/sample2.xml   src/core/fresh-site/src/documentation/content/xdocs/samples/index.xml   src/core/fresh-site/src/documentation/content/xdocs/samples/subdir/index.xml   src/core/fresh-site/src/documentation/content/xdocs/samples/ascii-art.xml   src/core/fresh-site/src/documentation/content/xdocs/index.xml   ===================================================================                                                                                      Changed <!DOCTYPE ...> to use Document V1.3                                                                                    src/core/fresh-site/src/documentation/content/xdocs/samples/faq.xml   ===================================================================                                                                                      Changed <!DOCTYPE ...> to use FAQ V1.3                                                                                    build.xml   ===================================================================                                                                                      Added <include> elements for the new V1.3 and V2.0 dtds                                                                                              - oOo -                                                                                  j174-r22915.zip contains the following net new additions                                                                                    src/core/context/resources/schema/dtd/howto-v13.dtd   src/core/context/resources/schema/dtd/faq-v13.dtd   src/core/context/resources/schema/dtd/document-v13.dtd   src/core/context/resources/schema/dtd/v20/   src/core/context/resources/schema/dtd/v20/todo-v20.dtd   src/core/context/resources/schema/dtd/v20/todo-v20.mod   src/core/context/resources/schema/dtd/v20/howto-v20.dtd   src/core/context/resources/schema/dtd/v20/changes-v20.dtd   src/core/context/resources/schema/dtd/v20/changes-v20.mod   src/core/context/resources/schema/dtd/v20/document-v20.dtd   src/core/context/resources/schema/dtd/v20/document-v20.mod   src/core/context/resources/schema/dtd/v20/faq-v20.dtd   src/core/context/resources/schema/dtd/v20/faq-v20.mod   src/core/context/resources/schema/dtd/todo-v13.dtd   src/core/context/resources/schema/dtd/changes-v13.dtd   src/core/context/resources/schema/dtd/document-v13.mod   src/core/context/resources/stylesheets/docv20todocv13.xsl   src/core/context/resources/stylesheets/faqv20tofaqv13.xsl
        Hide
        Rick Tessner added a comment -
        Hi all,
                                                                                        
        I've finally had a chance to put a new patch together for J174. This
        patch replaces the previously uploaded attachments: forrest-j174.patch and forrest-j174.zip.
                                                                                        
        The next two files uploaded are changes based on the discussions on
        the dev@forrest list
          http://marc.theaimsgroup.com/?l=forrest-dev&m=108741074104198&w=2
                                                                                        
        I'll be uploading two files:
                                                                                        
          j174-r22915.patch
          j174-r22915.zip
                                                                                        
                    - oOo -
                                                                                        
        j174-r22915.patch (the "svn diff") contains the following changes:
                                                                                        
          src/core/context/skins/common/xslt/fo/document2fo.xsl
          ===================================================================
                                                                                        
            Added a template for p[@class='quote'] to handle quoted paragraphs
            in PDF.
                                                                                        
          src/core/context/forrest.xmap
          ===================================================================
                                                                                        
            Added <sourcetype> and <map:when> elements for todo V1.3, changes V1.3,
            howto V1.3 todo V2.0, changes V2.0, howto V2.0 and document V2.0.
                                                                                        
          src/core/context/sitemap.xmap
          ===================================================================
                                                                                        
            Changed the <doctype-public> and <doctype-system> elements for
            the "xml-document" serializer to V1.3 instead of V1.2
                                                                                        
          src/core/context/resources/schema/catalog.xcat
          src/core/context/resources/schema/catalog
          ===================================================================
                                                                                        
            Added identifiers for all the V1.3 and V2.0 dtds / mods
                                                                                        
          src/core/context/resources/stylesheets/openoffice-writer2forrest.xsl
          ===================================================================
                                                                                        
            Changed <xsl:output> doctype-public and doctype-system attributes
            to point to V1.3
                                                                                        
          src/core/context/faq.xmap
          ===================================================================
                                                                                        
            Added <sourcetype> and <map:when> elements for FAQ V1.3 and V2.0
                                                                                        
          src/core/fresh-site/src/documentation/skinconf.xml
          ===================================================================
                                                                                        
            Added sample <extra-css> to handle a 'quote' class on <p> elements.
            Mirrors the change done for the common/xslt/fo/document2fo.xsl for
            PDF.
                                                                                        
          src/core/fresh-site/src/documentation/content/xdocs/samples/sample.xml
          ===================================================================
                                                                                        
            Changed <!DOCTYPE ...> to use Document V1.3 and added a sample
            paragraph, <p>, with the 'quote' class.
                                                                                        
          src/core/fresh-site/src/documentation/content/xdocs/samples/sample2.xml
          src/core/fresh-site/src/documentation/content/xdocs/samples/index.xml
          src/core/fresh-site/src/documentation/content/xdocs/samples/subdir/index.xml
          src/core/fresh-site/src/documentation/content/xdocs/samples/ascii-art.xml
          src/core/fresh-site/src/documentation/content/xdocs/index.xml
          ===================================================================
                                                                                        
            Changed <!DOCTYPE ...> to use Document V1.3
                                                                                        
          src/core/fresh-site/src/documentation/content/xdocs/samples/faq.xml
          ===================================================================
                                                                                        
            Changed <!DOCTYPE ...> to use FAQ V1.3
                                                                                        
          build.xml
          ===================================================================
                                                                                        
            Added <include> elements for the new V1.3 and V2.0 dtds
                                                                                        
                    - oOo -
                                                                                        
        j174-r22915.zip contains the following net new additions
                                                                                        
          src/core/context/resources/schema/dtd/howto-v13.dtd
          src/core/context/resources/schema/dtd/faq-v13.dtd
          src/core/context/resources/schema/dtd/document-v13.dtd
          src/core/context/resources/schema/dtd/v20/
          src/core/context/resources/schema/dtd/v20/todo-v20.dtd
          src/core/context/resources/schema/dtd/v20/todo-v20.mod
          src/core/context/resources/schema/dtd/v20/howto-v20.dtd
          src/core/context/resources/schema/dtd/v20/changes-v20.dtd
          src/core/context/resources/schema/dtd/v20/changes-v20.mod
          src/core/context/resources/schema/dtd/v20/document-v20.dtd
          src/core/context/resources/schema/dtd/v20/document-v20.mod
          src/core/context/resources/schema/dtd/v20/faq-v20.dtd
          src/core/context/resources/schema/dtd/v20/faq-v20.mod
          src/core/context/resources/schema/dtd/todo-v13.dtd
          src/core/context/resources/schema/dtd/changes-v13.dtd
          src/core/context/resources/schema/dtd/document-v13.mod
          src/core/context/resources/stylesheets/docv20todocv13.xsl
          src/core/context/resources/stylesheets/faqv20tofaqv13.xsl
        Show
        Rick Tessner added a comment - Hi all,                                                                                  I've finally had a chance to put a new patch together for J174. This patch replaces the previously uploaded attachments: forrest-j174.patch and forrest-j174.zip.                                                                                  The next two files uploaded are changes based on the discussions on the dev@forrest list    http://marc.theaimsgroup.com/?l=forrest-dev&m=108741074104198&w=2                                                                                  I'll be uploading two files:                                                                                    j174-r22915.patch   j174-r22915.zip                                                                                              - oOo -                                                                                  j174-r22915.patch (the "svn diff") contains the following changes:                                                                                    src/core/context/skins/common/xslt/fo/document2fo.xsl   ===================================================================                                                                                      Added a template for p[@class='quote'] to handle quoted paragraphs     in PDF.                                                                                    src/core/context/forrest.xmap   ===================================================================                                                                                      Added <sourcetype> and <map:when> elements for todo V1.3, changes V1.3,     howto V1.3 todo V2.0, changes V2.0, howto V2.0 and document V2.0.                                                                                    src/core/context/sitemap.xmap   ===================================================================                                                                                      Changed the <doctype-public> and <doctype-system> elements for     the "xml-document" serializer to V1.3 instead of V1.2                                                                                    src/core/context/resources/schema/catalog.xcat   src/core/context/resources/schema/catalog   ===================================================================                                                                                      Added identifiers for all the V1.3 and V2.0 dtds / mods                                                                                    src/core/context/resources/stylesheets/openoffice-writer2forrest.xsl   ===================================================================                                                                                      Changed <xsl:output> doctype-public and doctype-system attributes     to point to V1.3                                                                                    src/core/context/faq.xmap   ===================================================================                                                                                      Added <sourcetype> and <map:when> elements for FAQ V1.3 and V2.0                                                                                    src/core/fresh-site/src/documentation/skinconf.xml   ===================================================================                                                                                      Added sample <extra-css> to handle a 'quote' class on <p> elements.     Mirrors the change done for the common/xslt/fo/document2fo.xsl for     PDF.                                                                                    src/core/fresh-site/src/documentation/content/xdocs/samples/sample.xml   ===================================================================                                                                                      Changed <!DOCTYPE ...> to use Document V1.3 and added a sample     paragraph, <p>, with the 'quote' class.                                                                                    src/core/fresh-site/src/documentation/content/xdocs/samples/sample2.xml   src/core/fresh-site/src/documentation/content/xdocs/samples/index.xml   src/core/fresh-site/src/documentation/content/xdocs/samples/subdir/index.xml   src/core/fresh-site/src/documentation/content/xdocs/samples/ascii-art.xml   src/core/fresh-site/src/documentation/content/xdocs/index.xml   ===================================================================                                                                                      Changed <!DOCTYPE ...> to use Document V1.3                                                                                    src/core/fresh-site/src/documentation/content/xdocs/samples/faq.xml   ===================================================================                                                                                      Changed <!DOCTYPE ...> to use FAQ V1.3                                                                                    build.xml   ===================================================================                                                                                      Added <include> elements for the new V1.3 and V2.0 dtds                                                                                              - oOo -                                                                                  j174-r22915.zip contains the following net new additions                                                                                    src/core/context/resources/schema/dtd/howto-v13.dtd   src/core/context/resources/schema/dtd/faq-v13.dtd   src/core/context/resources/schema/dtd/document-v13.dtd   src/core/context/resources/schema/dtd/v20/   src/core/context/resources/schema/dtd/v20/todo-v20.dtd   src/core/context/resources/schema/dtd/v20/todo-v20.mod   src/core/context/resources/schema/dtd/v20/howto-v20.dtd   src/core/context/resources/schema/dtd/v20/changes-v20.dtd   src/core/context/resources/schema/dtd/v20/changes-v20.mod   src/core/context/resources/schema/dtd/v20/document-v20.dtd   src/core/context/resources/schema/dtd/v20/document-v20.mod   src/core/context/resources/schema/dtd/v20/faq-v20.dtd   src/core/context/resources/schema/dtd/v20/faq-v20.mod   src/core/context/resources/schema/dtd/todo-v13.dtd   src/core/context/resources/schema/dtd/changes-v13.dtd   src/core/context/resources/schema/dtd/document-v13.mod   src/core/context/resources/stylesheets/docv20todocv13.xsl   src/core/context/resources/stylesheets/faqv20tofaqv13.xsl
        Hide
        Nicola Ken Barozzi added a comment -
        Great! :-)

        Just one thing... we have a document-2.0 DTD in SVN, could you please take a look at that and see if maybe it's better to put the attribute on that DTD?

        We could then decide to "delete" the 2.0 and have a 1.3 or use the 2.0.
        Show
        Nicola Ken Barozzi added a comment - Great! :-) Just one thing... we have a document-2.0 DTD in SVN, could you please take a look at that and see if maybe it's better to put the attribute on that DTD? We could then decide to "delete" the 2.0 and have a 1.3 or use the 2.0.
        Hide
        Rick Tessner added a comment -
        This is a zip containing all the new v13 dtds and document-v13.mod
        Show
        Rick Tessner added a comment - This is a zip containing all the new v13 dtds and document-v13.mod
        Hide
        Rick Tessner added a comment -
        I've created a patch to define DTDs for v1.3 which adds the class attribute to all the elements.

        The next attachment will be a zip of the new V1.3 dtds. The change itself was very simple, but since it is a change to a published DTD, it was necessary to create a series of new DTD files and modify the various xmaps to understand the new DTDs.

        In addition, the samples were upgraded to use the new DTDs and the sample/sample.xml includes a quote paragraph with a definition of <p class='quote'>.

        The skinconf.xml defines some <extra-css> to handle this class.

        Unfortunately, the default skin (forrest seed ; forrest site) does not currently handle extra-css definitions so that CSS is not actually used. It is with the tigris-style, krysalis, etc.
        Show
        Rick Tessner added a comment - I've created a patch to define DTDs for v1.3 which adds the class attribute to all the elements. The next attachment will be a zip of the new V1.3 dtds. The change itself was very simple, but since it is a change to a published DTD, it was necessary to create a series of new DTD files and modify the various xmaps to understand the new DTDs. In addition, the samples were upgraded to use the new DTDs and the sample/sample.xml includes a quote paragraph with a definition of <p class='quote'>. The skinconf.xml defines some <extra-css> to handle this class. Unfortunately, the default skin (forrest seed ; forrest site) does not currently handle extra-css definitions so that CSS is not actually used. It is with the tigris-style, krysalis, etc.
        Hide
        Nicola Ken Barozzi added a comment -
        It shouyld be in 0.6, or else the extra-css part in skinconf is of no use.
        Show
        Nicola Ken Barozzi added a comment - It shouyld be in 0.6, or else the extra-css part in skinconf is of no use.

          People

          • Assignee:
            David Crossley
            Reporter:
            Nicola Ken Barozzi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development