Forrest
  1. Forrest
  2. FOR-146

Issues with //skinconfig and document2html.xsl

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.6
    • Fix Version/s: 0.6
    • Component/s: Skins (general issues)
    • Labels:
      None
    • Environment:
      copyless branch, SuSE 9.0, java 1.4.2

      Description

      There's a bit of an issue with the change to //skinconf (other than the PDF one).

      Using aggregation is a great idea for the skin configuration. Unfortunately, where it's being done means that some of the configuration bits are not available when desired.

      In particular, any requests for configuration information done by document2html.xsl will not result in any information being returned. This includes, by default, the configuration information for

            * disable-print-link
            * disable-pdf-link
            * disable-xml-link
            * toc/@location
            * disable-external-link-image
            * obfuscate-mail-links

      This is because the aggregation of the skinconf happens at the pipeline matching "*.html". This pipeline aggregates skinconf.xml, tab-*, menu-* and body-*.

      The items above (disable-*-link, etc) are handled in the pipeline for body-* by the document2html.xsl transformation sheet. That pipeline does NOT have access to the skinconf at this point. It would if the aggregation was done in the "body-*" pipeline.

      There are a couple of ways of solving this:

           1. Move the aggregation to the body-* pipeline. The "*.html"
      will
              then also have access to the skinconf. However, if this is
              done, it should probably be done for the tab-* and menu-*
              pipelines as well. Currently, it doesn't look like these last
              two pipelines make use of anything in the skinconf, but that may
              not always be the case. Not too fond of this one.
           2. Move the skinning bits out of document2html and handle it all
              within the "skinit" resource. This may require putting place
              holder tags in the html generated by document2html that "skinit"
              can then replace with proper skinconf values. I like this
              option better than #1.
           3. Go back to using document(). Don't like this option either.

      Thoughts? Any other options? More explanation required? BTW, I'm
      seeing this on the copyless branch.

        Activity

        David Crossley made changes -
        Resolution Fixed
        Status Assigned Closed
        David Crossley made changes -
        Assignee crossley
        Juan Jose Pablos made changes -
        issue.field.fixfor 0.6
        Rick Tessner made changes -
        Field Original Value New Value
        Attachment forrest.copyless.patch
        Rick Tessner created issue -

          People

          • Assignee:
            David Crossley
            Reporter:
            Rick Tessner
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development