Forrest
  1. Forrest
  2. FOR-1205

In the tigris skin the @import statements have syntactic errors

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8
    • Fix Version/s: 0.9
    • Component/s: Core operations
    • Labels:
      None
    • Other Info:
      Patch available

      Description

      With the tigris skin the following statements appear in the HTML files:

      <style type="text/css">
                /* */
                @import "
                ../
      skin/tigris.css";
                @import "
                ../
      skin/quirks.css";
                @import "
                ../
      skin/inst.css";
               /* */
              </style>

      This does not work since each URL should be on a single line:

      <style type="text/css">
                /* */
                @import "skin/tigris.css";
                @import "skin/quirks.css";
                @import "skin/inst.css";
               /* */
      </style>

      The error is in main/webapp/skins/tigris/xslt/html/site-to-xhtml.xsl:

              <style type="text/css">
                /* <![CDATA[ */
                @import "]]>
                <xsl:value-of select="$root"/>
      <![CDATA[skin/tigris.css";
                @import "]]>
                <xsl:value-of select="$root"/>
      <![CDATA[skin/quirks.css";
                @import "]]>
                <xsl:value-of select="$root"/>
      <![CDATA[skin/inst.css";
               /* ]]> */
              </style>

      which should be changed to:

              <style type="text/css">
                <xsl:text>
                /* <![CDATA[ */
                @import "]]></xsl:text>
                <xsl:value-of select="$root"/>
      <xsl:text><![CDATA[skin/tigris.css";
                import "]]></xsl:text>
                <xsl:value-of select="$root"/>
      <xsl:text><![CDATA[skin/quirks.css";
                @import "]]></xsl:text>
                <xsl:value-of select="$root"/>
      <xsl:text><![CDATA[skin/inst.css";
               /* ]]> */
      </xsl:text>
              </style>

        Activity

        Hide
        David Crossley added a comment -
        Thanks. Patch applied. I used "xsl:text" as suggested, but did it slightly differently.
        Show
        David Crossley added a comment - Thanks. Patch applied. I used "xsl:text" as suggested, but did it slightly differently.

          People

          • Assignee:
            Unassigned
            Reporter:
            Simon Pepping
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development