[FOP-718] Unterminated iteration in JPEGReader class

• Type: Bug
• Status: Open
• Resolution: Unresolved
• Affects Version/s: 0.20.5
• Component/s: image/unqualified
• Environment: Operating System: other; Platform: Other
• External issue ID: 22450
• Assignee: Unassigned
• Reporter: Zsolt Kulcsar
• Created: 15/Aug/03 09:18
• Updated: 16/Dec/12 08:20

Description

Look at the JPEGReader class in the org.apache.fop.image.analyzer package. In
the setDimension(...) method, can have an unterminated iteration. Why?

The method reads bytes from input stream, with a:

while ((marker = imageStream.read()) != MARK) {
...
}

Look at the description of the BufferedInputStream.read() method.: "If no byte
is available because the end of the stream has been reached, the value -1 is
returned.".

In the above iteration the author missed check this condition, so the method can
iterate over and over.

Sollution:
Check the end condition.

best regards: Zsolt Kulcsar