[FOP-2973] [PATCH] Cannot use custom schemes starting with "data" in resource resolving

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.5
• Fix Version/s: 2.7
• Assignee: J Frank
• Reporter: Erik Hofer
• Created: 05/Oct/20 15:57
• Updated: 12/Oct/21 14:11
• Resolved: 12/Oct/21 14:11

Description

In org.apache.fop.apps.io.InternalResourceResolver there is the following code:

    public Resource getResource(URI uri) throws IOException {
        if (uri.getScheme() != null && uri.getScheme().startsWith("data")) {
            return new Resource(resolveDataURI(uri.toASCIIString()));
        }
        return resourceResolver.getResource(resolveFromBase(uri));
    }

All URIs with a scheme starting with "data" are treated as a data URI. This means schemes like "dataFoo" are not delegated to the resourceResolver. I think this should be equals instead.

The string overload works correctly because it includes the colon:

  public Resource getResource(String stringUri) throws IOException, URISyntaxException {
        if (stringUri.startsWith("data:")) {
            return new Resource(resolveDataURI(stringUri));
        }
        return getResource(cleanURI(stringUri));
    }