[FOP-2810] [PATCH] Incomplete implementation of the simulate-style flag

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3
• Fix Version/s: 2.4
• Component/s: font/unqualified
• Flags: Patch
• Assignee: Chris Bowditch
• Reporter: Dan Caprioara
• Created: 08/Aug/18 11:59
• Updated: 05/Nov/19 16:06
• Resolved: 03/Sep/18 15:04

Description

The CustomFont.getSimulateStyle() is used only in:

org.apache.fop.render.pdf.PDFPainter.drawTextWithDX(int, int, String, FontTriplet, int, int, int[])

But not in:

org.apache.fop.render.pdf.PDFPainter.drawTextWithDP(int, int, String, FontTriplet, int, int, int[][])

As a result some of the font styling is not applied.

Modifying the above method with the following patch seem to fix the problem:

...
           boolean simulateStyle = tf instanceof CustomFont && ((CustomFont) tf).getSimulateStyle();
            
            // PATCH START 
            // Taken from #drawTextWithDX method
            double shear = 0;
          
            if (simulateStyle) {
                //Adding this breaks the PDF: generator.add("q\n")
                if (triplet.getWeight() == 700) {
                    generator.add("2 Tr 0.31543 w\n");
                }
                if (triplet.getStyle().equals("italic")) {
                    shear = 0.333;
                }
            }
            // PATCH END
            tu.writeTextMatrix(new AffineTransform(1, 0, shear, -1, x / 1000f, y / 1000f));
            tu.updateTf(fk, fsPoints, true);
           generator.updateCharacterSpacing(letterSpacing / 1000f);
...